librato/librato-rack

View on GitHub
lib/librato/rack/worker.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method compensated_repeat has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def compensated_repeat(period, first_run = nil)
        next_run = first_run || start_time(period)
        until @interrupt do
          now = Time.now
          if now >= next_run
Severity: Minor
Found in lib/librato/rack/worker.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start_time has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def start_time(period)
        if @sync
          earliest = Time.now + period
          # already on a whole minute
          return earliest if earliest.sec == 0
Severity: Minor
Found in lib/librato/rack/worker.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status