LibreNMS/Alert/Transport/Ciscospark.php
Method configTemplate has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function configTemplate(): array
{
return [
'config' => [
[The method deliverAlert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$msg = strip_tags($alert_data['msg']);
$mtype = 'text';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused private fields such as '$MAX_MSG_SIZE'. Open
Open
private static int $MAX_MSG_SIZE = 7435;- Read upRead up
- Exclude checks
UnusedPrivateField
Since: 0.2
Detects when a private field is declared and/or assigned a value, but not used.
Example
class Something
{
private static $FOO = 2; // Unused
private $i = 5; // Unused
private $j = 6;
public function addOne()
{
return $this->j++;
}
}Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield
The property $MAX_MSG_SIZE is not named in camelCase. Open
Open
class Ciscospark extends Transport
{
protected string $name = 'Cisco Webex Teams';
// This is the total length minus 4 bytes for ellipses.
private static int $MAX_MSG_SIZE = 7435;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}