Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/Alert/Transport/Playsms.php

Summary

Maintainability
A
1 hr
Test Coverage

Method configTemplate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function configTemplate(): array
    {
        return [
            'config' => [
                [
Severity: Minor
Found in LibreNMS/Alert/Transport/Playsms.php - About 1 hr to fix

    Avoid variables with short names like $to. Configured minimum length is 3.
    Open

            $to = preg_split('/([,\r\n]+)/', $this->config['playsms-mobiles']);
    Severity: Minor
    Found in LibreNMS/Alert/Transport/Playsms.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status