Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/Alert/Transport/Smseagle.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method configTemplate has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function configTemplate(): array
    {
        return [
            'config' => [
                [
Severity: Minor
Found in LibreNMS/Alert/Transport/Smseagle.php - About 1 hr to fix

    The method deliverAlert uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $params['access_token'] = $this->config['smseagle-token'];
        }
    Severity: Minor
    Found in LibreNMS/Alert/Transport/Smseagle.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public static function configTemplate(): array
    {
        return [
            'config' => [
                [
    Severity: Major
    Found in LibreNMS/Alert/Transport/Smseagle.php and 2 other locations - About 4 hrs to fix
    LibreNMS/Alert/Transport/Canopsis.php on lines 74..117
    LibreNMS/Alert/Transport/Signalwire.php on lines 49..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 165.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status