librenms/librenms

View on GitHub
LibreNMS/Data/Source/SnmpQueryInterface.php

Summary

Maintainability
A
0 mins
Test Coverage

The method numericIndex has a boolean flag argument $numericIndex, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function numericIndex(bool $numericIndex = true): SnmpQueryInterface;

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method numeric has a boolean flag argument $numeric, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function numeric(bool $numeric = true): SnmpQueryInterface;

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method mibs has a boolean flag argument $append, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function mibs(array $mibs, bool $append = true): SnmpQueryInterface;

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status