Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/OS/Ios.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method discoverWirelessClients has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function discoverWirelessClients()
    {
        $device = $this->getDeviceArray();

        if (! Str::startsWith($device['hardware'], 'AIR-') && ! Str::contains($device['hardware'], 'ciscoAIR')) {
Severity: Minor
Found in LibreNMS/OS/Ios.php - About 1 hr to fix

    Function discoverWirelessClients has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function discoverWirelessClients()
    {
        $device = $this->getDeviceArray();

        if (! Str::startsWith($device['hardware'], 'AIR-') && ! Str::contains($device['hardware'], 'ciscoAIR')) {
    Severity: Minor
    Found in LibreNMS/OS/Ios.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused local variables such as '$_unused'.
    Open

            foreach ($data as $index => $_unused) {
    Severity: Minor
    Found in LibreNMS/OS/Ios.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    There are no issues that match your filters.

    Category
    Status