librenms/librenms

View on GitHub
LibreNMS/OS/Pfsense.php

Summary

Maintainability
D
2 days
Test Coverage

Method pollOS has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function pollOS(DataStorageInterface $datastore): void
    {
        $oids = snmp_get_multi($this->getDeviceArray(), [
            'pfStateTableCount.0',
            'pfStateTableSearches.0',
Severity: Major
Found in LibreNMS/OS/Pfsense.php - About 4 hrs to fix

    Function pollOS has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function pollOS(DataStorageInterface $datastore): void
        {
            $oids = snmp_get_multi($this->getDeviceArray(), [
                'pfStateTableCount.0',
                'pfStateTableSearches.0',
    Severity: Minor
    Found in LibreNMS/OS/Pfsense.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method pollOS() has 145 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        public function pollOS(DataStorageInterface $datastore): void
        {
            $oids = snmp_get_multi($this->getDeviceArray(), [
                'pfStateTableCount.0',
                'pfStateTableSearches.0',
    Severity: Minor
    Found in LibreNMS/OS/Pfsense.php by phpmd

    The method pollOS() has an NPath complexity of 1024. The configured NPath complexity threshold is 200.
    Open

        public function pollOS(DataStorageInterface $datastore): void
        {
            $oids = snmp_get_multi($this->getDeviceArray(), [
                'pfStateTableCount.0',
                'pfStateTableSearches.0',
    Severity: Minor
    Found in LibreNMS/OS/Pfsense.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method pollOS() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

        public function pollOS(DataStorageInterface $datastore): void
        {
            $oids = snmp_get_multi($this->getDeviceArray(), [
                'pfStateTableCount.0',
                'pfStateTableSearches.0',
    Severity: Minor
    Found in LibreNMS/OS/Pfsense.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfCounterMatch'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('matches', 'COUNTER', 0);
    
                $fields = [
                    'matches' => $oids[0]['pfCounterMatch'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfCounterShort'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('short', 'COUNTER', 0);
    
                $fields = [
                    'short' => $oids[0]['pfCounterShort'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfStateTableRemovals'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('removals', 'COUNTER', 0);
    
                $fields = [
                    'removals' => $oids[0]['pfStateTableRemovals'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfStateTableSearches'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('searches', 'COUNTER', 0);
    
                $fields = [
                    'searches' => $oids[0]['pfStateTableSearches'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfCounterFragment'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('fragmented', 'COUNTER', 0);
    
                $fields = [
                    'fragmented' => $oids[0]['pfCounterFragment'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfCounterMemDrop'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('memdropped', 'COUNTER', 0);
    
                $fields = [
                    'memdropped' => $oids[0]['pfCounterMemDrop'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfStateTableInserts'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('inserts', 'COUNTER', 0);
    
                $fields = [
                    'inserts' => $oids[0]['pfStateTableInserts'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfStateTableCount'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('states', 'GAUGE', 0);
    
                $fields = [
                    'states' => $oids[0]['pfStateTableCount'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfCounterBadOffset'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('badoffset', 'COUNTER', 0);
    
                $fields = [
                    'badoffset' => $oids[0]['pfCounterBadOffset'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 154..165
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

            if (is_numeric($oids[0]['pfCounterNormalize'] ?? null)) {
                $rrd_def = RrdDefinition::make()->addDataset('normalized', 'COUNTER', 0);
    
                $fields = [
                    'normalized' => $oids[0]['pfCounterNormalize'],
    Severity: Major
    Found in LibreNMS/OS/Pfsense.php and 32 other locations - About 1 hr to fix
    LibreNMS/OS/Gaia.php on lines 20..30
    LibreNMS/OS/Gaia.php on lines 35..45
    LibreNMS/OS/Gaia.php on lines 50..60
    LibreNMS/OS/Panos.php on lines 162..173
    LibreNMS/OS/Panos.php on lines 174..185
    LibreNMS/OS/Panos.php on lines 186..197
    LibreNMS/OS/Panos.php on lines 198..209
    LibreNMS/OS/Panos.php on lines 210..221
    LibreNMS/OS/Panos.php on lines 222..233
    LibreNMS/OS/Panos.php on lines 234..245
    LibreNMS/OS/Panos.php on lines 246..257
    LibreNMS/OS/Panos.php on lines 258..269
    LibreNMS/OS/Panos.php on lines 270..281
    LibreNMS/OS/Panos.php on lines 282..293
    LibreNMS/OS/Panos.php on lines 294..305
    LibreNMS/OS/Panos.php on lines 306..317
    LibreNMS/OS/Panos.php on lines 318..329
    LibreNMS/OS/Panos.php on lines 330..341
    LibreNMS/OS/Panos.php on lines 342..353
    LibreNMS/OS/Panos.php on lines 354..365
    LibreNMS/OS/Panos.php on lines 366..377
    LibreNMS/OS/Panos.php on lines 378..389
    LibreNMS/OS/Panos.php on lines 390..401
    LibreNMS/OS/Pfsense.php on lines 50..61
    LibreNMS/OS/Pfsense.php on lines 63..74
    LibreNMS/OS/Pfsense.php on lines 76..87
    LibreNMS/OS/Pfsense.php on lines 89..100
    LibreNMS/OS/Pfsense.php on lines 102..113
    LibreNMS/OS/Pfsense.php on lines 115..126
    LibreNMS/OS/Pfsense.php on lines 128..139
    LibreNMS/OS/Pfsense.php on lines 141..152
    LibreNMS/OS/Pfsense.php on lines 167..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status