Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/OS/Pmp.php

Summary

Maintainability
D
3 days
Test Coverage

File Pmp.php has 456 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Pmp.php
 *
 * Cambium
Severity: Minor
Found in LibreNMS/OS/Pmp.php - About 6 hrs to fix

    Method pollOS has 136 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function pollOS(DataStorageInterface $datastore): void
    {
        // Migrated to Wireless Sensor
        $fec = snmp_get_multi_oid($this->getDeviceArray(), ['fecInErrorsCount.0', 'fecOutErrorsCount.0', 'fecCRCError.0'], '-OQUs', 'WHISP-BOX-MIBV2-MIB');
        if (is_numeric($fec['fecInErrorsCount.0'] ?? null) && is_numeric($fec['fecOutErrorsCount.0'] ?? null)) {
    Severity: Major
    Found in LibreNMS/OS/Pmp.php - About 5 hrs to fix

      Method discoverWirelessUtilization has 92 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function discoverWirelessUtilization()
    {
        $lowdownlink = '.1.3.6.1.4.1.161.19.3.1.12.1.1.0'; // WHISP-APS-MIB::frUtlLowTotalDownlinkUtilization
        $lowuplink = '.1.3.6.1.4.1.161.19.3.1.12.1.2.0'; // WHISP-APS-MIB::frUtlLowTotalUplinkUtilization
        $meddownlink = '.1.3.6.1.4.1.161.19.3.1.12.2.1.0'; // WHISP-APS-MIB::frUtlMedTotalDownlinkUtilization
      Severity: Major
      Found in LibreNMS/OS/Pmp.php - About 3 hrs to fix

        Function discoverOS has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function discoverOS(Device $device): void
    {
        parent::discoverOS($device); // yaml
        $data = snmp_get_multi_oid($this->getDeviceArray(), ['boxDeviceType.0', 'bhTimingMode.0', 'boxDeviceTypeID.0', 'productTypeName.0'], '-OQUs', 'WHISP-BOX-MIBV2-MIB');
        $device->features = $data['boxDeviceType.0'] ?? null;
        Severity: Minor
        Found in LibreNMS/OS/Pmp.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method discoverOS has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function discoverOS(Device $device): void
    {
        parent::discoverOS($device); // yaml
        $data = snmp_get_multi_oid($this->getDeviceArray(), ['boxDeviceType.0', 'bhTimingMode.0', 'boxDeviceTypeID.0', 'productTypeName.0'], '-OQUs', 'WHISP-BOX-MIBV2-MIB');
        $device->features = $data['boxDeviceType.0'] ?? null;
        Severity: Minor
        Found in LibreNMS/OS/Pmp.php - About 1 hr to fix

          Function pollOS has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function pollOS(DataStorageInterface $datastore): void
    {
        // Migrated to Wireless Sensor
        $fec = snmp_get_multi_oid($this->getDeviceArray(), ['fecInErrorsCount.0', 'fecOutErrorsCount.0', 'fecCRCError.0'], '-OQUs', 'WHISP-BOX-MIBV2-MIB');
        if (is_numeric($fec['fecInErrorsCount.0'] ?? null) && is_numeric($fec['fecOutErrorsCount.0'] ?? null)) {
          Severity: Minor
          Found in LibreNMS/OS/Pmp.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method discoverWirelessErrors has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function discoverWirelessErrors()
    {
        $fecInErrorsCount = '.1.3.6.1.4.1.161.19.3.3.1.95.0';
        $fecOutErrorsCount = '.1.3.6.1.4.1.161.19.3.3.1.97.0';
        $fecCRCError = '.1.3.6.1.4.1.161.19.3.3.1.223.0';
          Severity: Minor
          Found in LibreNMS/OS/Pmp.php - About 1 hr to fix

            Method discoverWirelessSnr has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function discoverWirelessSnr()
    {
        if ($this->isAp()) {
            $snr_horizontal = '.1.3.6.1.4.1.161.19.3.1.4.1.84.2'; // WHISP-APS-MIB::signalToNoiseRatioHorizontal.2
            $snr_vertical = '.1.3.6.1.4.1.161.19.3.1.4.1.74.2'; //WHISP-APS-MIB::signalToNoiseRatioVertical.2
            Severity: Minor
            Found in LibreNMS/OS/Pmp.php - About 1 hr to fix

              The method pollOS() has an NPath complexity of 38880. The configured NPath complexity threshold is 200.
              Open

                  public function pollOS(DataStorageInterface $datastore): void
    {
        // Migrated to Wireless Sensor
        $fec = snmp_get_multi_oid($this->getDeviceArray(), ['fecInErrorsCount.0', 'fecOutErrorsCount.0', 'fecCRCError.0'], '-OQUs', 'WHISP-BOX-MIBV2-MIB');
        if (is_numeric($fec['fecInErrorsCount.0'] ?? null) && is_numeric($fec['fecOutErrorsCount.0'] ?? null)) {
              Severity: Minor
              Found in LibreNMS/OS/Pmp.php by phpmd

              NPathComplexity

              Since: 0.1

              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

              Example

              class Foo {
    function bar() {
        // lots of complicated code
    }
}

              Source https://phpmd.org/rules/codesize.html#npathcomplexity

              The method pollOS() has 154 lines of code. Current threshold is set to 100. Avoid really long methods.
              Open

                  public function pollOS(DataStorageInterface $datastore): void
    {
        // Migrated to Wireless Sensor
        $fec = snmp_get_multi_oid($this->getDeviceArray(), ['fecInErrorsCount.0', 'fecOutErrorsCount.0', 'fecCRCError.0'], '-OQUs', 'WHISP-BOX-MIBV2-MIB');
        if (is_numeric($fec['fecInErrorsCount.0'] ?? null) && is_numeric($fec['fecOutErrorsCount.0'] ?? null)) {
              Severity: Minor
              Found in LibreNMS/OS/Pmp.php by phpmd

              The method pollOS() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
              Open

                  public function pollOS(DataStorageInterface $datastore): void
    {
        // Migrated to Wireless Sensor
        $fec = snmp_get_multi_oid($this->getDeviceArray(), ['fecInErrorsCount.0', 'fecOutErrorsCount.0', 'fecCRCError.0'], '-OQUs', 'WHISP-BOX-MIBV2-MIB');
        if (is_numeric($fec['fecInErrorsCount.0'] ?? null) && is_numeric($fec['fecOutErrorsCount.0'] ?? null)) {
              Severity: Minor
              Found in LibreNMS/OS/Pmp.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              The method discoverWirelessSsr uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
            $ssr = '.1.3.6.1.4.1.161.19.3.2.2.108.0'; //WHISP-SMSSM-MIB::signalStrengthRatio.0
        }
              Severity: Minor
              Found in LibreNMS/OS/Pmp.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method discoverWirelessSnr uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
            $snr_horizontal = '.1.3.6.1.4.1.161.19.3.2.2.106.0'; // WHISP-SMS-MIB::signalToNoiseRatioSMHorizontal.0
            $snr_vertical = '.1.3.6.1.4.1.161.19.3.2.2.95.0'; //WHISP-SMS-MIB::signalToNoiseRatioSMVertical.0
        }
              Severity: Minor
              Found in LibreNMS/OS/Pmp.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (is_numeric($lastLevel)) {
            $rrd_def = RrdDefinition::make()->addDataset('last', 'GAUGE', -100, 0);
            $fields = [
                'last' => $lastLevel,
            ];
              Severity: Minor
              Found in LibreNMS/OS/Pmp.php and 1 other location - About 50 mins to fix
              LibreNMS/OS/Procurve.php on lines 42..53

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 97.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status