Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/OS/Powerconnect.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method pollNac has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function pollNac()
    {
        $nac = new Collection();

        $authMgrEnabled = SnmpQuery::mibs(['DNOS-AUTHENTICATION-MANAGER-MIB'])->mibDir('dell')->hideMib()->enumStrings()->get('agentAuthMgrAdminMode.0')->value();
Severity: Minor
Found in LibreNMS/OS/Powerconnect.php - About 1 hr to fix

    Method discoverProcessors has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function discoverProcessors()
    {
        $device = $this->getDeviceArray();
        if (Str::startsWith($device['sysObjectID'], [
            '.1.3.6.1.4.1.674.10895.3020',
    Severity: Minor
    Found in LibreNMS/OS/Powerconnect.php - About 1 hr to fix

      Function decode_string has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function decode_string(string $s): string
    {
        $s = str_replace("\n", ' ', $s);
        $characters = explode(' ', $s);
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function pollNac has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function pollNac()
    {
        $nac = new Collection();

        $authMgrEnabled = SnmpQuery::mibs(['DNOS-AUTHENTICATION-MANAGER-MIB'])->mibDir('dell')->hideMib()->enumStrings()->get('agentAuthMgrAdminMode.0')->value();
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method pollProcessors uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                $data += $this->pollVxworksProcessors([$processor]);
            }
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid variables with short names like $s. Configured minimum length is 3.
      Open

          private static function decode_string(string $s): string
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Method name "Powerconnect::decode_string" is not in camel caps format
      Open

          private static function decode_string(string $s): string
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php by phpcodesniffer

      Line indented incorrectly; expected 12 spaces, found 16
      Open

                      default => $row['agentAuthMgrClientAuthstatus']
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php by phpcodesniffer

      Space before opening parenthesis of function call prohibited
      Open

                  $row['agentAuthMgrClientAuthstatus'] = match ($row['agentAuthMgrClientAuthstatus']) {
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php by phpcodesniffer

      Line indented incorrectly; expected at least 16 spaces, found 12
      Open

                  $row['agentAuthMgrPortHostMode'] = $hostmode[$row['agentAuthMgrInterface']]['agentAuthMgrPortHostMode'] ?? '';
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php by phpcodesniffer

      The method decode_string is not named in camelCase.
      Open

          private static function decode_string(string $s): string
    {
        $s = str_replace("\n", ' ', $s);
        $characters = explode(' ', $s);
      Severity: Minor
      Found in LibreNMS/OS/Powerconnect.php by phpmd

      CamelCaseMethodName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name methods.

      Example

      class ClassName {
    public function get_name() {
    }
}

      Source

      There are no issues that match your filters.

      Category
      Status