Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/OS/Ptp670.php

Summary

Maintainability
D
2 days
Test Coverage

Method discoverWirelessRate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function discoverWirelessRate()
    {
        $receive = '.1.3.6.1.4.1.17713.11.20.1.0'; //CAMBIUM-PTP670-MIB::receiveDataRate.0
        $transmit = '.1.3.6.1.4.1.17713.11.20.2.0'; //CAMBIUM-PTP670-MIB::transmitDataRate.0
        $aggregate = '.1.3.6.1.4.1.17713.11.20.3.0'; //CAMBIUM-PTP670-MIB::aggregateDataRate.0
Severity: Major
Found in LibreNMS/OS/Ptp670.php - About 2 hrs to fix

    Method discoverWirelessPower has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function discoverWirelessPower()
    {
        $transmit = '.1.3.6.1.4.1.17713.11.12.4.0'; //CAMBIUM-PTP670-MIB::transmitPower.0
        $receive = '.1.3.6.1.4.1.17713.11.12.12.0'; //CAMBIUM-PTP670-MIB::rawReceivePower.0
    Severity: Minor
    Found in LibreNMS/OS/Ptp670.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
/**
 * ptp670.php
 *
 * Cambium
      Severity: Major
      Found in LibreNMS/OS/Ptp670.php and 1 other location - About 1 day to fix
      LibreNMS/OS/Ptp650.php on lines 1..169

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 407.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status