librenms/librenms

Method discoverStpInstances has 49 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function discoverStpInstances(?string $vlan = null): Collection
    {
        $protocol = SnmpQuery::get('BRIDGE-MIB::dot1dStpProtocolSpecification.0')->value();
        // 1 = unknown (mstp?), 3 = ieee8021d

Method discoverStpPorts has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function discoverStpPorts(Collection $stpInstances): Collection
    {
        $ports = new Collection;
        foreach ($stpInstances as $instance) {
            $vlan_ports = SnmpQuery::context("$instance->vlan", 'vlan-')

Avoid too many return statements within this method.

Open

        return $ports;

Avoid too many return statements within this method.

Open

                    return true;

Missing class import via use statement (line '75', column '25').

Open

        $instance = new \App\Models\Stp([

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid variables with short names like $dp. Configured minimum length is 3.

Open

    private function designatedPort(string $dp): int

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}