LibreNMS/Polling/ModuleStatus.php
The method isEnabledAndDeviceUp has a boolean flag argument $check_snmp, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function isEnabledAndDeviceUp(Device $device, bool $check_snmp = true): bool
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid variables with short names like $os. Configured minimum length is 3. Open
Open
public ?bool $os = null,
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public bool $global,
- Exclude checks
Opening parenthesis of a multi-line function call must be the last content on the line Open
Open
return sprintf('Module %s: Global %s | OS %s | Device %s | Manual %s',
- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public ?bool $os = null,
- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public ?bool $device = null,
- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
public ?bool $manual = null,
- Exclude checks