Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/Snmptrap/Handlers/AdvaNetworkElementAlmTrap.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$device'.
Open

    public function handle(Device $device, Trap $trap)
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/AdvaNetworkElementAlmTrap.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        $almObjName = $trap->getOidData($trap->findOid('CM-ALARM-MIB::cmNetworkElementAlmObjectName'));
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/AdvaNetworkElementAlmTrap.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            default => Severity::Info,
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/AdvaNetworkElementAlmTrap.php by phpcodesniffer

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        $almDescr = $trap->getOidData($trap->findOid('CM-ALARM-MIB::cmNetworkElementAlmDescr'));
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/AdvaNetworkElementAlmTrap.php by phpcodesniffer

Space before opening parenthesis of function call prohibited
Open

        $logSeverity = match ($alSeverity) {
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/AdvaNetworkElementAlmTrap.php by phpcodesniffer

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        $trap->log("Alarming Element: $almObjName Description: $almDescr Severity: $alSeverity", $logSeverity);
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/AdvaNetworkElementAlmTrap.php by phpcodesniffer

There are no issues that match your filters.

Category
Status