Sign upLogin

librenms/librenms

View on GitHub
Star
LibreNMS/Snmptrap/Handlers/BgpBackwardTransition.php

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * BgpBackwardTransition.php
 *
 * -Description-
Severity: Major
Found in LibreNMS/Snmptrap/Handlers/BgpBackwardTransition.php and 1 other location - About 5 hrs to fix
LibreNMS/Snmptrap/Handlers/BgpEstablished.php on lines 1..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 193.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Only one argument is allowed per line in a multi-line function call
Open

            $trap->log('SNMP Trap: BGP Down ' . $bgpPeer->bgpPeerIdentifier . ' ' . AutonomousSystem::get($bgpPeer->bgpPeerRemoteAs)->name() . ' is now ' . $bgpPeer->bgpPeerState, severity: Severity::Error, type: 'bgpPeer',
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/BgpBackwardTransition.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

            $trap->log('SNMP Trap: BGP Down ' . $bgpPeer->bgpPeerIdentifier . ' ' . AutonomousSystem::get($bgpPeer->bgpPeerRemoteAs)->name() . ' is now ' . $bgpPeer->bgpPeerState, severity: Severity::Error, type: 'bgpPeer',
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/BgpBackwardTransition.php by phpcodesniffer

Opening parenthesis of a multi-line function call must be the last content on the line
Open

            $trap->log('SNMP Trap: BGP Down ' . $bgpPeer->bgpPeerIdentifier . ' ' . AutonomousSystem::get($bgpPeer->bgpPeerRemoteAs)->name() . ' is now ' . $bgpPeer->bgpPeerState, severity: Severity::Error, type: 'bgpPeer',
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/BgpBackwardTransition.php by phpcodesniffer

Multi-line function call not indented correctly; expected 12 spaces but found 16
Open

                reference: $bgpPeerIp);
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/BgpBackwardTransition.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                reference: $bgpPeerIp);
Severity: Minor
Found in LibreNMS/Snmptrap/Handlers/BgpBackwardTransition.php by phpcodesniffer

There are no issues that match your filters.

Category
Status