LibreNMS/Util/DynamicConfigItem.php
Function checkValue has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
Open
public function checkValue($value)
{
if ($this->validate) {
return $this->buildValidator($value)->passes();
} elseif ($this->type == 'boolean') {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
DynamicConfigItem has 28 functions (exceeds 20 allowed). Consider refactoring. Open
Open
#[\AllowDynamicProperties]
class DynamicConfigItem implements \ArrayAccess
{
public $name;
public $group;The class DynamicConfigItem has an overall complexity of 58 which is very high. The configured complexity threshold is 50. Open
Open
class DynamicConfigItem implements \ArrayAccess
{
public $name;
public $group;
public $section;- Exclude checks
Method checkValue has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function checkValue($value)
{
if ($this->validate) {
return $this->buildValidator($value)->passes();
} elseif ($this->type == 'boolean') {Avoid too many return statements within this method. Open
Open
return in_array($value, array_keys($this->options));Avoid too many return statements within this method. Open
Open
return false;Avoid too many return statements within this method. Open
Open
return (bool) preg_match('/^#?[0-9a-fA-F]{6}([0-9a-fA-F]{2})?$/', $value);Avoid too many return statements within this method. Open
Open
return filter_var($value, FILTER_VALIDATE_EMAIL);Avoid too many return statements within this method. Open
Open
return is_file($value) && is_executable($value);Avoid too many return statements within this method. Open
Open
return ! is_array($value);Avoid too many return statements within this method. Open
Open
return false;Avoid too many return statements within this method. Open
Open
return is_array($value); // this should probably have more complex validation via validator rulesAvoid too many return statements within this method. Open
Open
return true;Avoid too many return statements within this method. Open
Open
return is_dir($value);Avoid too many return statements within this method. Open
Open
return false;The method checkValue() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10. Open
Open
public function checkValue($value)
{
if ($this->validate) {
return $this->buildValidator($value)->passes();
} elseif ($this->type == 'boolean') {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}