Function graphRow
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
public static function graphRow($graph_array, $print = false)
{
if (session('widescreen')) {
if (! array_key_exists('height', $graph_array)) {
$graph_array['height'] = '110';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method graphRow
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function graphRow($graph_array, $print = false)
{
if (session('widescreen')) {
if (! array_key_exists('height', $graph_array)) {
$graph_array['height'] = '110';
Method appStateIcon
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function appStateIcon($app_state)
{
switch ($app_state) {
case 'OK':
$icon = '';
Method percentageBar
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
public static function percentageBar($width, $height, $percent, $left_text = '', $right_text = '', $warn = null, $shadow = null, $colors = null)
Function appStateIcon
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public static function appStateIcon($app_state)
{
switch ($app_state) {
case 'OK':
$icon = '';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method graphRow() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public static function graphRow($graph_array, $print = false)
{
if (session('widescreen')) {
if (! array_key_exists('height', $graph_array)) {
$graph_array['height'] = '110';
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The method graphRow has a boolean flag argument $print, which is a certain sign of a Single Responsibility Principle violation. Open
public static function graphRow($graph_array, $print = false)
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method graphRow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$graph_array['width'] = $screen_width - 70;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method graphRow uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if (! array_key_exists('height', $graph_array)) {
$graph_array['height'] = '100';
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$period_text'. Open
foreach ($periods as $period => $period_text) {
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}