librenms/librenms

View on GitHub
includes/discovery/functions.inc.php

Summary

Maintainability
F
2 wks
Test Coverage

File functions.inc.php has 1132 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * LibreNMS Network Management and Monitoring System
 * Copyright (C) 2006-2011, Observium Developers - http://www.observium.org
Severity: Major
Found in includes/discovery/functions.inc.php - About 2 days to fix

    Function discovery_process has a Cognitive Complexity of 126 (exceeds 5 allowed). Consider refactoring.
    Open

    function discovery_process(&$valid, $os, $sensor_class, $pre_cache)
    {
        $discovery = $os->getDiscovery('sensors');
        $device = $os->getDeviceArray();
    
    
    Severity: Minor
    Found in includes/discovery/functions.inc.php - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_device_divisor has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

    function get_device_divisor($device, $os_version, $sensor_type, $oid)
    {
        if ($device['os'] == 'poweralert') {
            if ($sensor_type == 'current' || $sensor_type == 'frequency') {
                if (version_compare($os_version, '12.06.0068', '>=')) {
    Severity: Minor
    Found in includes/discovery/functions.inc.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function discover_sensor has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

    function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
    {
        $guess_limits = Config::get('sensors.guess_limits', true);
    
        $low_limit = set_null($low_limit);
    Severity: Minor
    Found in includes/discovery/functions.inc.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method discover_sensor has 126 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
    {
        $guess_limits = Config::get('sensors.guess_limits', true);
    
        $low_limit = set_null($low_limit);
    Severity: Major
    Found in includes/discovery/functions.inc.php - About 5 hrs to fix

      Method discovery_process has 113 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function discovery_process(&$valid, $os, $sensor_class, $pre_cache)
      {
          $discovery = $os->getDiscovery('sensors');
          $device = $os->getDeviceArray();
      
      
      Severity: Major
      Found in includes/discovery/functions.inc.php - About 4 hrs to fix

        Function discover_device has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

        function discover_device(&$device, $force_module = false)
        {
            if ($device['snmp_disable'] == '1') {
                return true;
            }
        Severity: Minor
        Found in includes/discovery/functions.inc.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function build_bgp_peers has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

        function build_bgp_peers($device, $data, $peer2)
        {
            d_echo("Peers : $data\n");
            $remove = [
                'ARISTA-BGP4V2-MIB::aristaBgp4V2PeerRemoteAs.1.',
        Severity: Minor
        Found in includes/discovery/functions.inc.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function find_device_id has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

        function find_device_id($name = '', $ip = '', $mac_address = '')
        {
            $where = [];
            $params = [];
        
        
        Severity: Minor
        Found in includes/discovery/functions.inc.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method discover_sensor has 20 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
        Severity: Major
        Found in includes/discovery/functions.inc.php - About 2 hrs to fix

          Function can_skip_discovery has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

          function can_skip_discovery($sysName, $sysDescr = '', $platform = '')
          {
              if ($sysName) {
                  foreach ((array) Config::get('autodiscovery.xdp_exclude.sysname_regexp') as $needle) {
                      if (preg_match($needle . 'i', $sysName)) {
          Severity: Minor
          Found in includes/discovery/functions.inc.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function discover_process_ipv4 has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

          function discover_process_ipv4(&$valid_v4, $device, int $ifIndex, $ipv4_address, $mask, $context_name = '')
          {
              $cidr = IPv4::netmask2cidr($mask);
              try {
                  $ipv4 = new IPv4($ipv4_address . '/' . $cidr);
          Severity: Minor
          Found in includes/discovery/functions.inc.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method discover_entity_physical has 19 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
          Severity: Major
          Found in includes/discovery/functions.inc.php - About 2 hrs to fix

            Function find_port_id has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            function find_port_id($description, $identifier = '', $device_id = 0, $mac_address = null)
            {
                if (! ($device_id || $mac_address)) {
                    return 0;
                }
            Severity: Minor
            Found in includes/discovery/functions.inc.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function discover_new_device has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            function discover_new_device($hostname, $device, $method, $interface = null)
            {
                d_echo("discovering $hostname\n");
            
                if (IP::isValid($hostname)) {
            Severity: Minor
            Found in includes/discovery/functions.inc.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method find_device_id has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function find_device_id($name = '', $ip = '', $mac_address = '')
            {
                $where = [];
                $params = [];
            
            
            Severity: Major
            Found in includes/discovery/functions.inc.php - About 2 hrs to fix

              Method discover_new_device has 54 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function discover_new_device($hostname, $device, $method, $interface = null)
              {
                  d_echo("discovering $hostname\n");
              
                  if (IP::isValid($hostname)) {
              Severity: Major
              Found in includes/discovery/functions.inc.php - About 2 hrs to fix

                Method discover_entity_physical has 53 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                {
                    d_echo("Discover Inventory Item: $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex\n");
                
                    if ($entPhysicalDescr || $entPhysicalName) {
                Severity: Major
                Found in includes/discovery/functions.inc.php - About 2 hrs to fix

                  Method discover_device has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function discover_device(&$device, $force_module = false)
                  {
                      if ($device['snmp_disable'] == '1') {
                          return true;
                      }
                  Severity: Major
                  Found in includes/discovery/functions.inc.php - About 2 hrs to fix

                    Method get_device_divisor has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function get_device_divisor($device, $os_version, $sensor_type, $oid)
                    {
                        if ($device['os'] == 'poweralert') {
                            if ($sensor_type == 'current' || $sensor_type == 'frequency') {
                                if (version_compare($os_version, '12.06.0068', '>=')) {
                    Severity: Minor
                    Found in includes/discovery/functions.inc.php - About 2 hrs to fix

                      Method discover_link has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function discover_link($local_port_id, $protocol, $remote_port_id, $remote_hostname, $remote_port, $remote_platform, $remote_version, $local_device_id, $remote_device_id)
                      {
                          global $link_exists;
                      
                          d_echo("Discover link: $local_port_id, $protocol, $remote_port_id, $remote_hostname, $remote_port, $remote_platform, $remote_version, $remote_device_id\n");
                      Severity: Minor
                      Found in includes/discovery/functions.inc.php - About 1 hr to fix

                        Method build_bgp_peers has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function build_bgp_peers($device, $data, $peer2)
                        {
                            d_echo("Peers : $data\n");
                            $remove = [
                                'ARISTA-BGP4V2-MIB::aristaBgp4V2PeerRemoteAs.1.',
                        Severity: Minor
                        Found in includes/discovery/functions.inc.php - About 1 hr to fix

                          Method discover_process_ipv4 has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function discover_process_ipv4(&$valid_v4, $device, int $ifIndex, $ipv4_address, $mask, $context_name = '')
                          {
                              $cidr = IPv4::netmask2cidr($mask);
                              try {
                                  $ipv4 = new IPv4($ipv4_address . '/' . $cidr);
                          Severity: Minor
                          Found in includes/discovery/functions.inc.php - About 1 hr to fix

                            Method find_port_id has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function find_port_id($description, $identifier = '', $device_id = 0, $mac_address = null)
                            {
                                if (! ($device_id || $mac_address)) {
                                    return 0;
                                }
                            Severity: Minor
                            Found in includes/discovery/functions.inc.php - About 1 hr to fix

                              Function discover_storage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function discover_storage(&$valid, $device, $index, $type, $mib, $descr, $size, $units, $used = null)
                              {
                                  if (ignore_storage($device['os'], $descr)) {
                                      return;
                                  }
                              Severity: Minor
                              Found in includes/discovery/functions.inc.php - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method discover_process_ipv6 has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              function discover_process_ipv6(&$valid, $ifIndex, $ipv6_address, $ipv6_prefixlen, $ipv6_origin, $context_name = '')
                              {
                                  global $device;
                              
                                  if (! IPv6::isValid($ipv6_address, true)) {
                              Severity: Minor
                              Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                Function build_cbgp_peers has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                Open

                                function build_cbgp_peers($device, $peer, $af_data, $peer2)
                                {
                                    d_echo('afi data :: ');
                                    d_echo($af_data);
                                
                                
                                Severity: Minor
                                Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Method discover_storage has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                function discover_storage(&$valid, $device, $index, $type, $mib, $descr, $size, $units, $used = null)
                                {
                                    if (ignore_storage($device['os'], $descr)) {
                                        return;
                                    }
                                Severity: Minor
                                Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                  Method build_cbgp_peers has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                  function build_cbgp_peers($device, $peer, $af_data, $peer2)
                                  {
                                      d_echo('afi data :: ');
                                      d_echo($af_data);
                                  
                                  
                                  Severity: Minor
                                  Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                    Consider simplifying this complex logical expression.
                                    Open

                                            if ($force_module === true ||
                                                $device_module_status ||
                                                ($os_module_status && $device_module_status === null) ||
                                                ($module_status && ! isset($os_module_status) && $device_module_status === null)
                                            ) {
                                    Severity: Critical
                                    Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                      Consider simplifying this complex logical expression.
                                      Open

                                              if ($oid == $sensor_entry['sensor_oid'] &&
                                                  $descr == $sensor_entry['sensor_descr'] &&
                                                  $multiplier == $sensor_entry['sensor_multiplier'] &&
                                                  $divisor == $sensor_entry['sensor_divisor'] &&
                                                  $entPhysicalIndex_measured == $sensor_entry['entPhysicalIndex_measured'] &&
                                      Severity: Critical
                                      Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                        Method sensor_limit has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                        function sensor_limit($class, $current)
                                        {
                                            // matching an empty case executes code until a break is reached
                                            switch ($class) {
                                                case 'temperature':
                                        Severity: Minor
                                        Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                          Function sensors has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                                          Open

                                          function sensors($types, $os, $valid, $pre_cache = [])
                                          {
                                              $device = &$os->getDeviceArray();
                                              foreach ((array) $types as $sensor_class) {
                                                  echo ucfirst($sensor_class) . ': ';
                                          Severity: Minor
                                          Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                          Cognitive Complexity

                                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                          A method's cognitive complexity is based on a few simple rules:

                                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                          • Code is considered more complex for each "break in the linear flow of the code"
                                          • Code is considered more complex when "flow breaking structures are nested"

                                          Further reading

                                          Method sensor_low_limit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                                          Open

                                          function sensor_low_limit($class, $current)
                                          {
                                              // matching an empty case executes code until a break is reached
                                              switch ($class) {
                                                  case 'temperature':
                                          Severity: Minor
                                          Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                            Method discover_link has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                            Open

                                            function discover_link($local_port_id, $protocol, $remote_port_id, $remote_hostname, $remote_port, $remote_platform, $remote_version, $local_device_id, $remote_device_id)
                                            Severity: Major
                                            Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                              Method discover_storage has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                              Open

                                              function discover_storage(&$valid, $device, $index, $type, $mib, $descr, $size, $units, $used = null)
                                              Severity: Major
                                              Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                                Method add_cbgp_peer has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                                Open

                                                function add_cbgp_peer($device, $peer, $afi, $safi)
                                                {
                                                    if (dbFetchCell('SELECT COUNT(*) from `bgpPeers_cbgp` WHERE device_id = ? AND bgpPeerIdentifier = ? AND afi=? AND safi=?', [$device['device_id'], $peer['ip'], $afi, $safi]) == 0) {
                                                        $cbgp = [
                                                            'device_id' => $device['device_id'],
                                                Severity: Minor
                                                Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                                  Method add_bgp_peer has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                                                  Open

                                                  function add_bgp_peer($device, $peer)
                                                  {
                                                      if (dbFetchCell('SELECT COUNT(*) from `bgpPeers` WHERE device_id = ? AND bgpPeerIdentifier = ?', [$device['device_id'], $peer['ip']]) < '1') {
                                                          $bgpPeers = [
                                                              'device_id' => $device['device_id'],
                                                  Severity: Minor
                                                  Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                                    Function check_valid_sensors has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                    function check_valid_sensors($device, $class, $valid, $poller_type = 'snmp')
                                                    {
                                                        $entries = dbFetchRows('SELECT * FROM sensors AS S, devices AS D WHERE S.sensor_class=? AND S.device_id = D.device_id AND D.device_id = ? AND S.poller_type = ?', [$class, $device['device_id'], $poller_type]);
                                                    
                                                        if (count($entries)) {
                                                    Severity: Minor
                                                    Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Function can_skip_sensor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                    function can_skip_sensor($device, $sensor_class = '', $sensor_descr = '')
                                                    {
                                                        if (! empty($sensor_class) && (Config::getOsSetting($device['os'], "disabled_sensors.$sensor_class") || Config::get("disabled_sensors.$sensor_class"))) {
                                                            return true;
                                                        }
                                                    Severity: Minor
                                                    Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Function discover_process_ipv6 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                    function discover_process_ipv6(&$valid, $ifIndex, $ipv6_address, $ipv6_prefixlen, $ipv6_origin, $context_name = '')
                                                    {
                                                        global $device;
                                                    
                                                        if (! IPv6::isValid($ipv6_address, true)) {
                                                    Severity: Minor
                                                    Found in includes/discovery/functions.inc.php - About 1 hr to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Function ignore_storage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                    function ignore_storage($os, $descr)
                                                    {
                                                        foreach (Config::getCombined($os, 'ignore_mount') as $im) {
                                                            if ($im == $descr) {
                                                                d_echo("ignored $descr (matched: $im)\n");
                                                    Severity: Minor
                                                    Found in includes/discovery/functions.inc.php - About 55 mins to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Function sensor_limit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                    function sensor_limit($class, $current)
                                                    {
                                                        // matching an empty case executes code until a break is reached
                                                        switch ($class) {
                                                            case 'temperature':
                                                    Severity: Minor
                                                    Found in includes/discovery/functions.inc.php - About 55 mins to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Function sensor_low_limit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                    function sensor_low_limit($class, $current)
                                                    {
                                                        // matching an empty case executes code until a break is reached
                                                        switch ($class) {
                                                            case 'temperature':
                                                    Severity: Minor
                                                    Found in includes/discovery/functions.inc.php - About 45 mins to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Method discover_process_ipv6 has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                                    Open

                                                    function discover_process_ipv6(&$valid, $ifIndex, $ipv6_address, $ipv6_prefixlen, $ipv6_origin, $context_name = '')
                                                    Severity: Minor
                                                    Found in includes/discovery/functions.inc.php - About 45 mins to fix

                                                      Function discover_entity_physical has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                                      Open

                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                      {
                                                          d_echo("Discover Inventory Item: $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex\n");
                                                      
                                                          if ($entPhysicalDescr || $entPhysicalName) {
                                                      Severity: Minor
                                                      Found in includes/discovery/functions.inc.php - About 45 mins to fix

                                                      Cognitive Complexity

                                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                      A method's cognitive complexity is based on a few simple rules:

                                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                      • Code is considered more complex for each "break in the linear flow of the code"
                                                      • Code is considered more complex when "flow breaking structures are nested"

                                                      Further reading

                                                      Method discover_process_ipv4 has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                                      Open

                                                      function discover_process_ipv4(&$valid_v4, $device, int $ifIndex, $ipv4_address, $mask, $context_name = '')
                                                      Severity: Minor
                                                      Found in includes/discovery/functions.inc.php - About 45 mins to fix

                                                        Method discover_juniAtmVp has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                        Open

                                                        function discover_juniAtmVp(&$valid, $device, $port_id, $vp_id, $vp_descr)
                                                        Severity: Minor
                                                        Found in includes/discovery/functions.inc.php - About 35 mins to fix

                                                          Function discover_link has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                                          Open

                                                          function discover_link($local_port_id, $protocol, $remote_port_id, $remote_hostname, $remote_port, $remote_platform, $remote_version, $local_device_id, $remote_device_id)
                                                          {
                                                              global $link_exists;
                                                          
                                                              d_echo("Discover link: $local_port_id, $protocol, $remote_port_id, $remote_hostname, $remote_port, $remote_platform, $remote_version, $remote_device_id\n");
                                                          Severity: Minor
                                                          Found in includes/discovery/functions.inc.php - About 35 mins to fix

                                                          Cognitive Complexity

                                                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                          A method's cognitive complexity is based on a few simple rules:

                                                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                          • Code is considered more complex for each "break in the linear flow of the code"
                                                          • Code is considered more complex when "flow breaking structures are nested"

                                                          Further reading

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                      return 1;
                                                          Severity: Major
                                                          Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                    return 1;
                                                            Severity: Major
                                                            Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                  return 10;
                                                              Severity: Major
                                                              Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                            return $remote_device->device_id;
                                                                Severity: Major
                                                                Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                              return 1;
                                                                  Severity: Major
                                                                  Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                                    return 1;
                                                                    Severity: Major
                                                                    Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                                  return 10;
                                                                      Severity: Major
                                                                      Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                return 1;
                                                                        Severity: Major
                                                                        Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                          Avoid too many return statements within this method.
                                                                          Open

                                                                                      return 100;
                                                                          Severity: Major
                                                                          Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                            Avoid too many return statements within this method.
                                                                            Open

                                                                                        return 60;
                                                                            Severity: Major
                                                                            Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                              Avoid too many return statements within this method.
                                                                              Open

                                                                                      return false;
                                                                              Severity: Major
                                                                              Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                                Avoid too many return statements within this method.
                                                                                Open

                                                                                    return false;
                                                                                Severity: Major
                                                                                Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                                  return 10;
                                                                                  Severity: Major
                                                                                  Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                                    return 60;
                                                                                    Severity: Major
                                                                                    Found in includes/discovery/functions.inc.php - About 30 mins to fix

                                                                                      The function get_device_divisor() has an NPath complexity of 1188. The configured NPath complexity threshold is 200.
                                                                                      Open

                                                                                      function get_device_divisor($device, $os_version, $sensor_type, $oid)
                                                                                      {
                                                                                          if ($device['os'] == 'poweralert') {
                                                                                              if ($sensor_type == 'current' || $sensor_type == 'frequency') {
                                                                                                  if (version_compare($os_version, '12.06.0068', '>=')) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      NPathComplexity

                                                                                      Since: 0.1

                                                                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                                      Example

                                                                                      class Foo {
                                                                                          function bar() {
                                                                                              // lots of complicated code
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                                      The function discover_sensor() has an NPath complexity of 420228. The configured NPath complexity threshold is 200.
                                                                                      Open

                                                                                      function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
                                                                                      {
                                                                                          $guess_limits = Config::get('sensors.guess_limits', true);
                                                                                      
                                                                                          $low_limit = set_null($low_limit);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      NPathComplexity

                                                                                      Since: 0.1

                                                                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                                      Example

                                                                                      class Foo {
                                                                                          function bar() {
                                                                                              // lots of complicated code
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                                      The function discovery_process() has an NPath complexity of 87592328. The configured NPath complexity threshold is 200.
                                                                                      Open

                                                                                      function discovery_process(&$valid, $os, $sensor_class, $pre_cache)
                                                                                      {
                                                                                          $discovery = $os->getDiscovery('sensors');
                                                                                          $device = $os->getDeviceArray();
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      NPathComplexity

                                                                                      Since: 0.1

                                                                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                                      Example

                                                                                      class Foo {
                                                                                          function bar() {
                                                                                              // lots of complicated code
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                                      The function discovery_process() has 151 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                                                      Open

                                                                                      function discovery_process(&$valid, $os, $sensor_class, $pre_cache)
                                                                                      {
                                                                                          $discovery = $os->getDiscovery('sensors');
                                                                                          $device = $os->getDeviceArray();
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      The function discover_sensor() has 160 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                                                      Open

                                                                                      function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
                                                                                      {
                                                                                          $guess_limits = Config::get('sensors.guess_limits', true);
                                                                                      
                                                                                          $low_limit = set_null($low_limit);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      The function discover_sensor has 20 parameters. Consider reducing the number of parameters to less than 10.
                                                                                      Open

                                                                                      function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
                                                                                      {
                                                                                          $guess_limits = Config::get('sensors.guess_limits', true);
                                                                                      
                                                                                          $low_limit = set_null($low_limit);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      The function discover_entity_physical has 19 parameters. Consider reducing the number of parameters to less than 10.
                                                                                      Open

                                                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                                                      {
                                                                                          d_echo("Discover Inventory Item: $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex\n");
                                                                                      
                                                                                          if ($entPhysicalDescr || $entPhysicalName) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      The function find_port_id() has an NPath complexity of 234. The configured NPath complexity threshold is 200.
                                                                                      Open

                                                                                      function find_port_id($description, $identifier = '', $device_id = 0, $mac_address = null)
                                                                                      {
                                                                                          if (! ($device_id || $mac_address)) {
                                                                                              return 0;
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      NPathComplexity

                                                                                      Since: 0.1

                                                                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                                      Example

                                                                                      class Foo {
                                                                                          function bar() {
                                                                                              // lots of complicated code
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                                      The function find_device_id() has an NPath complexity of 1008. The configured NPath complexity threshold is 200.
                                                                                      Open

                                                                                      function find_device_id($name = '', $ip = '', $mac_address = '')
                                                                                      {
                                                                                          $where = [];
                                                                                          $params = [];
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      NPathComplexity

                                                                                      Since: 0.1

                                                                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                                      Example

                                                                                      class Foo {
                                                                                          function bar() {
                                                                                              // lots of complicated code
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                                      The function discover_device() has an NPath complexity of 3332. The configured NPath complexity threshold is 200.
                                                                                      Open

                                                                                      function discover_device(&$device, $force_module = false)
                                                                                      {
                                                                                          if ($device['snmp_disable'] == '1') {
                                                                                              return true;
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      NPathComplexity

                                                                                      Since: 0.1

                                                                                      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                                      Example

                                                                                      class Foo {
                                                                                          function bar() {
                                                                                              // lots of complicated code
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                                      The function sensor_limit() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function sensor_limit($class, $current)
                                                                                      {
                                                                                          // matching an empty case executes code until a break is reached
                                                                                          switch ($class) {
                                                                                              case 'temperature':
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function discovery_process() has a Cyclomatic Complexity of 41. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function discovery_process(&$valid, $os, $sensor_class, $pre_cache)
                                                                                      {
                                                                                          $discovery = $os->getDiscovery('sensors');
                                                                                          $device = $os->getDeviceArray();
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function can_skip_sensor() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function can_skip_sensor($device, $sensor_class = '', $sensor_descr = '')
                                                                                      {
                                                                                          if (! empty($sensor_class) && (Config::getOsSetting($device['os'], "disabled_sensors.$sensor_class") || Config::get("disabled_sensors.$sensor_class"))) {
                                                                                              return true;
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function find_port_id() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function find_port_id($description, $identifier = '', $device_id = 0, $mac_address = null)
                                                                                      {
                                                                                          if (! ($device_id || $mac_address)) {
                                                                                              return 0;
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function sensor_low_limit() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function sensor_low_limit($class, $current)
                                                                                      {
                                                                                          // matching an empty case executes code until a break is reached
                                                                                          switch ($class) {
                                                                                              case 'temperature':
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function build_bgp_peers() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function build_bgp_peers($device, $data, $peer2)
                                                                                      {
                                                                                          d_echo("Peers : $data\n");
                                                                                          $remove = [
                                                                                              'ARISTA-BGP4V2-MIB::aristaBgp4V2PeerRemoteAs.1.',
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function discover_sensor() has a Cyclomatic Complexity of 36. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
                                                                                      {
                                                                                          $guess_limits = Config::get('sensors.guess_limits', true);
                                                                                      
                                                                                          $low_limit = set_null($low_limit);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function discover_device() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function discover_device(&$device, $force_module = false)
                                                                                      {
                                                                                          if ($device['snmp_disable'] == '1') {
                                                                                              return true;
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function can_skip_discovery() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function can_skip_discovery($sysName, $sysDescr = '', $platform = '')
                                                                                      {
                                                                                          if ($sysName) {
                                                                                              foreach ((array) Config::get('autodiscovery.xdp_exclude.sysname_regexp') as $needle) {
                                                                                                  if (preg_match($needle . 'i', $sysName)) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function find_device_id() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function find_device_id($name = '', $ip = '', $mac_address = '')
                                                                                      {
                                                                                          $where = [];
                                                                                          $params = [];
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function discover_new_device() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function discover_new_device($hostname, $device, $method, $interface = null)
                                                                                      {
                                                                                          d_echo("discovering $hostname\n");
                                                                                      
                                                                                          if (IP::isValid($hostname)) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function discover_process_ipv4() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function discover_process_ipv4(&$valid_v4, $device, int $ifIndex, $ipv4_address, $mask, $context_name = '')
                                                                                      {
                                                                                          $cidr = IPv4::netmask2cidr($mask);
                                                                                          try {
                                                                                              $ipv4 = new IPv4($ipv4_address . '/' . $cidr);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      The function get_device_divisor() has a Cyclomatic Complexity of 27. The configured cyclomatic complexity threshold is 10.
                                                                                      Open

                                                                                      function get_device_divisor($device, $os_version, $sensor_type, $oid)
                                                                                      {
                                                                                          if ($device['os'] == 'poweralert') {
                                                                                              if ($sensor_type == 'current' || $sensor_type == 'frequency') {
                                                                                                  if (version_compare($os_version, '12.06.0068', '>=')) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      CyclomaticComplexity

                                                                                      Since: 0.1

                                                                                      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                                      Example

                                                                                      // Cyclomatic Complexity = 11
                                                                                      class Foo {
                                                                                      1   public function example() {
                                                                                      2       if ($a == $b) {
                                                                                      3           if ($a1 == $b1) {
                                                                                                      fiddle();
                                                                                      4           } elseif ($a2 == $b2) {
                                                                                                      fiddle();
                                                                                                  } else {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      5       } elseif ($c == $d) {
                                                                                      6           while ($c == $d) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                      7        } elseif ($e == $f) {
                                                                                      8           for ($n = 0; $n < $h; $n++) {
                                                                                                      fiddle();
                                                                                                  }
                                                                                              } else {
                                                                                                  switch ($z) {
                                                                                      9               case 1:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      10              case 2:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                      11              case 3:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                      default:
                                                                                                          fiddle();
                                                                                                          break;
                                                                                                  }
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                                      Avoid using undefined variables such as '$high_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          echo "$descr: Cur $value, Low: $low_limit, Low Warn: $low_warn_limit, Warn: $warn_limit, High: $high_limit" . PHP_EOL;
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$low_warn_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          discover_sensor($valid['sensor'], $sensor_class, $device, $oid, $uindex, $sensor_name, $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $warn_limit, $high_limit, $value, 'snmp', $entPhysicalIndex, $entPhysicalIndex_measured, $user_function, $group, $data['rrd_type'] ?? 'GAUGE');
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$warn_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          echo "$descr: Cur $value, Low: $low_limit, Low Warn: $low_warn_limit, Warn: $warn_limit, High: $high_limit" . PHP_EOL;
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$warn_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          discover_sensor($valid['sensor'], $sensor_class, $device, $oid, $uindex, $sensor_name, $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $warn_limit, $high_limit, $value, 'snmp', $entPhysicalIndex, $entPhysicalIndex_measured, $user_function, $group, $data['rrd_type'] ?? 'GAUGE');
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$low_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          discover_sensor($valid['sensor'], $sensor_class, $device, $oid, $uindex, $sensor_name, $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $warn_limit, $high_limit, $value, 'snmp', $entPhysicalIndex, $entPhysicalIndex_measured, $user_function, $group, $data['rrd_type'] ?? 'GAUGE');
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$high_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          discover_sensor($valid['sensor'], $sensor_class, $device, $oid, $uindex, $sensor_name, $descr, $divisor, $multiplier, $low_limit, $low_warn_limit, $warn_limit, $high_limit, $value, 'snmp', $entPhysicalIndex, $entPhysicalIndex_measured, $user_function, $group, $data['rrd_type'] ?? 'GAUGE');
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$low_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          echo "$descr: Cur $value, Low: $low_limit, Low Warn: $low_warn_limit, Warn: $warn_limit, High: $high_limit" . PHP_EOL;
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$low_warn_limit' which will lead to PHP notices.
                                                                                      Open

                                                                                                          echo "$descr: Cur $value, Low: $low_limit, Low Warn: $low_warn_limit, Warn: $warn_limit, High: $high_limit" . PHP_EOL;
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      Avoid using undefined variables such as '$oid' which will lead to PHP notices.
                                                                                      Open

                                                                                                  unset($oid);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UndefinedVariable

                                                                                      Since: 2.8.0

                                                                                      Detects when a variable is used that has not been defined before.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar()
                                                                                          {
                                                                                              // $message is undefined
                                                                                              echo $message;
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                                                                                      The method discover_device has a boolean flag argument $force_module, which is a certain sign of a Single Responsibility Principle violation.
                                                                                      Open

                                                                                      function discover_device(&$device, $force_module = false)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      BooleanArgumentFlag

                                                                                      Since: 1.4.0

                                                                                      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                                                                                      Example

                                                                                      class Foo {
                                                                                          public function bar($flag = true) {
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                                                                                      Missing class import via use statement (line '139', column '19').
                                                                                      Open

                                                                                          $helper = new \LibreNMS\Polling\ConnectivityHelper(DeviceCache::getPrimary());
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      MissingImport

                                                                                      Since: 2.7.0

                                                                                      Importing all external classes in a file through use statements makes them clearly visible.

                                                                                      Example

                                                                                      function make() {
                                                                                          return new \stdClass();
                                                                                      }

                                                                                      Source http://phpmd.org/rules/cleancode.html#MissingImport

                                                                                      The method discover_device uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  echo "Module [ $module ] disabled globally.\n\n";
                                                                                              }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_sensor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                          } else {
                                                                                              $sensor_entry = dbFetchRow('SELECT * FROM `sensors` WHERE `sensor_class` = ? AND `device_id` = ? AND `sensor_type` = ? AND `sensor_index` = ?', [$class, $device['device_id'], $type, (string) $index]);
                                                                                      
                                                                                              if (! isset($high_limit)) {
                                                                                                  if ($guess_limits && ! $sensor_entry['sensor_limit']) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method get_device_divisor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                  } else {
                                                                                                      return 1;
                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discovery_process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                              } else {
                                                                                                                  $uindex = $data['index'];
                                                                                                              }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_storage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                  } else {
                                                                                                      $perc_warn = Config::get('storage_perc_warn', 60);
                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_entity_physical uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  echo '.';
                                                                                                  $update_data = [
                                                                                                      'entPhysicalIndex' => $entPhysicalIndex,
                                                                                                      'entPhysicalDescr' => $entPhysicalDescr,
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discovery_process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                              } else {
                                                                                                                  $value = (new UserFuncHelper($value, $snmp_data[$data['value']], $data))->{$user_function}();
                                                                                                              }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method build_cbgp_peers uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  $safi = array_pop($afisafi_tmp);
                                                                                                  $afi = array_pop($afisafi_tmp);
                                                                                                  $bgp_ip = str_replace(".$afi.$safi", '', $k);
                                                                                                  if ($device['os_group'] === 'arista') {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      Avoid assigning values to variables in if clauses and the like (line '1388', column '13').
                                                                                      Open

                                                                                      function find_device_id($name = '', $ip = '', $mac_address = '')
                                                                                      {
                                                                                          $where = [];
                                                                                          $params = [];
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      IfStatementAssignment

                                                                                      Since: 2.7.0

                                                                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($foo = 'bar') { // possible typo
                                                                                                  // ...
                                                                                              }
                                                                                              if ($baz = 0) { // always false
                                                                                                  // ...
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                                                                      The method discover_juniAtmVp uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                          } else {
                                                                                              echo '.';
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_new_device uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                          } else {
                                                                                              d_echo("Discovery failed: '$hostname' is not a valid ip or dns name\n");
                                                                                      
                                                                                              return false;
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_storage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                  } else {
                                                                                                      echo '.';
                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method build_bgp_peers uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  if (strstr($peer_ip, ':')) {
                                                                                                      $peer_ip_snmp = preg_replace('/:/', ' ', $peer_ip);
                                                                                                      $peer_ip = preg_replace('/(\S+\s+\S+)\s/', '$1:', $peer_ip_snmp);
                                                                                                      $peer_ip = str_replace('"', '', str_replace(' ', '', $peer_ip));
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      Avoid assigning values to variables in if clauses and the like (line '1400', column '13').
                                                                                      Open

                                                                                      function find_device_id($name = '', $ip = '', $mac_address = '')
                                                                                      {
                                                                                          $where = [];
                                                                                          $params = [];
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      IfStatementAssignment

                                                                                      Since: 2.7.0

                                                                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($foo = 'bar') { // possible typo
                                                                                                  // ...
                                                                                              }
                                                                                              if ($baz = 0) { // always false
                                                                                                  // ...
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                                                                      Avoid assigning values to variables in if clauses and the like (line '57', column '13').
                                                                                      Open

                                                                                      function discover_new_device($hostname, $device, $method, $interface = null)
                                                                                      {
                                                                                          d_echo("discovering $hostname\n");
                                                                                      
                                                                                          if (IP::isValid($hostname)) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      IfStatementAssignment

                                                                                      Since: 2.7.0

                                                                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($foo = 'bar') { // possible typo
                                                                                                  // ...
                                                                                              }
                                                                                              if ($baz = 0) { // always false
                                                                                                  // ...
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                                                                      The method discover_sensor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                  } else {
                                                                                                      // Use existing limit
                                                                                                      $low_limit = $sensor_entry['sensor_limit_low'];
                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_sensor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                  } else {
                                                                                                      // Use existing limit
                                                                                                      $high_limit = $sensor_entry['sensor_limit'];
                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_link uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                          } else {
                                                                                              $sql = 'SELECT `id`,`local_device_id`,`remote_platform`,`remote_version`,`remote_device_id`,`remote_port_id` FROM `links`';
                                                                                              $sql .= ' WHERE `remote_hostname` = ? AND `local_port_id` = ? AND `protocol` = ? AND `remote_port` = ?';
                                                                                              $data = dbFetchRow($sql, [$remote_hostname, $local_port_id, $protocol, $remote_port]);
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discovery_process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                      } else {
                                                                                                          $value = false;
                                                                                                      }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discovery_process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                                      } else {
                                                                                                                          $$limit = (new UserFuncHelper($$limit))->{$user_function}();
                                                                                                                      }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_link uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  $updated = dbUpdate($update_data, 'links', '`id` = ?', [$id]);
                                                                                                  echo 'U';
                                                                                                  d_echo("( $updated updated )");
                                                                                              }//end if
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method add_bgp_peer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                          } else {
                                                                                              dbUpdate(['bgpPeerRemoteAs' => $peer['as'], 'astext' => $peer['astext']], 'bgpPeers', 'device_id=? AND bgpPeerIdentifier=?', [$device['device_id'], $peer['ip']]);
                                                                                              echo '.';
                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_process_ipv4 uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  d_echo('No port id found for ifindex: ' . $ifIndex . PHP_EOL);
                                                                                              }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_sensor uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  $update = [
                                                                                                      'sensor_oid' => $oid,
                                                                                                      'sensor_descr' => $descr,
                                                                                                      'sensor_multiplier' => $multiplier,
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method discover_storage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                              } else {
                                                                                                  $updated = dbUpdate(['storage_descr' => $descr, 'storage_type' => $type, 'storage_units' => $units, 'storage_size' => $size], 'storage', '`device_id` = ? AND `storage_index` = ? AND `storage_mib` = ?', [$device['device_id'], $index, $mib]);
                                                                                                  if ($updated) {
                                                                                                      echo 'U';
                                                                                                  } else {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      Avoid assigning values to variables in if clauses and the like (line '1358', column '13').
                                                                                      Open

                                                                                      function find_device_id($name = '', $ip = '', $mac_address = '')
                                                                                      {
                                                                                          $where = [];
                                                                                          $params = [];
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      IfStatementAssignment

                                                                                      Since: 2.7.0

                                                                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($foo = 'bar') { // possible typo
                                                                                                  // ...
                                                                                              }
                                                                                              if ($baz = 0) { // always false
                                                                                                  // ...
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                                                                      The method discovery_process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                          } else {
                                                                                                              // We default to 1 for both divisors / multipliers so it should be safe to do the calculation using both.
                                                                                                              $value = ($value / $divisor) * $multiplier;
                                                                                                          }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      Avoid assigning values to variables in if clauses and the like (line '1382', column '13').
                                                                                      Open

                                                                                      function find_device_id($name = '', $ip = '', $mac_address = '')
                                                                                      {
                                                                                          $where = [];
                                                                                          $params = [];
                                                                                      
                                                                                      
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      IfStatementAssignment

                                                                                      Since: 2.7.0

                                                                                      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($foo = 'bar') { // possible typo
                                                                                                  // ...
                                                                                              }
                                                                                              if ($baz = 0) { // always false
                                                                                                  // ...
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                                                                                      The method discovery_process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                              } else {
                                                                                                                  $$limit = YamlDiscovery::getValueFromData($limit, $index, $data, $pre_cache, 'null');
                                                                                                                  if (is_numeric($$limit)) {
                                                                                                                      $$limit = ($$limit / $divisor) * $multiplier;
                                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method find_port_id uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                  } else {
                                                                                                      $statements[] = 'SELECT `port_id` FROM `ports` WHERE `device_id`=? AND (`ifDescr`=? OR `ifName`=?)';
                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      The method build_bgp_peers uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                                                                                      Open

                                                                                                  } else {
                                                                                                      // ipv4
                                                                                                      $peer_ip = implode('.', array_slice(explode('.', $peer_ip), -4));
                                                                                                  }
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ElseExpression

                                                                                      Since: 1.4.0

                                                                                      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          public function bar($flag)
                                                                                          {
                                                                                              if ($flag) {
                                                                                                  // one branch
                                                                                              } else {
                                                                                                  // another branch
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/cleancode.html#elseexpression

                                                                                      Avoid unused local variables such as '$v'.
                                                                                      Open

                                                                                          foreach ($af_data as $k => $v) {
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UnusedLocalVariable

                                                                                      Since: 0.2

                                                                                      Detects when a local variable is declared and/or assigned, but not used.

                                                                                      Example

                                                                                      class Foo {
                                                                                          public function doSomething()
                                                                                          {
                                                                                              $i = 5; // Unused
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                                                                      Avoid unused local variables such as '$oid'.
                                                                                      Open

                                                                                                  unset($oid);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UnusedLocalVariable

                                                                                      Since: 0.2

                                                                                      Detects when a local variable is declared and/or assigned, but not used.

                                                                                      Example

                                                                                      class Foo {
                                                                                          public function doSomething()
                                                                                          {
                                                                                              $i = 5; // Unused
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                                                                      Avoid unused parameters such as '$context_name'.
                                                                                      Open

                                                                                      function discover_process_ipv4(&$valid_v4, $device, int $ifIndex, $ipv4_address, $mask, $context_name = '')
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UnusedFormalParameter

                                                                                      Since: 0.2

                                                                                      Avoid passing parameters to methods or constructors and then not using those parameters.

                                                                                      Example

                                                                                      class Foo
                                                                                      {
                                                                                          private function bar($howdy)
                                                                                          {
                                                                                              // $howdy is not used
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                                                                                      Avoid unused local variables such as '$peertype'.
                                                                                      Open

                                                                                                  $peertype = array_shift($afisafi_tmp);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UnusedLocalVariable

                                                                                      Since: 0.2

                                                                                      Detects when a local variable is declared and/or assigned, but not used.

                                                                                      Example

                                                                                      class Foo {
                                                                                          public function doSomething()
                                                                                          {
                                                                                              $i = 5; // Unused
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                                                                      Avoid unused local variables such as '$vpninst_id'.
                                                                                      Open

                                                                                                  $vpninst_id = array_shift($afisafi_tmp);
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      UnusedLocalVariable

                                                                                      Since: 0.2

                                                                                      Detects when a local variable is declared and/or assigned, but not used.

                                                                                      Example

                                                                                      class Foo {
                                                                                          public function doSomething()
                                                                                          {
                                                                                              $i = 5; // Unused
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                                                                                      FIXME found
                                                                                      Open

                                                                                              // FIXME vv no $device!
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by fixme

                                                                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                                                                      Open

                                                                                              if ((string) $sensor_entry['sensor_limit_low_warn'] != (string) $low_warn_limit && $sensor_entry['sensor_custom'] == 'No') {
                                                                                                  $update = ['sensor_limit_low_warn' => $low_warn_limit];
                                                                                                  $updated = dbUpdate($update, 'sensors', '`sensor_id` = ?', [$sensor_entry['sensor_id']]);
                                                                                                  d_echo("( $updated updated )\n");
                                                                                      
                                                                                      
                                                                                      Severity: Major
                                                                                      Found in includes/discovery/functions.inc.php and 1 other location - About 3 hrs to fix
                                                                                      includes/discovery/functions.inc.php on lines 303..310

                                                                                      Duplicated Code

                                                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                                      Tuning

                                                                                      This issue has a mass of 156.

                                                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                                      Refactorings

                                                                                      Further Reading

                                                                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                                                                      Open

                                                                                              if ((string) $high_limit != (string) $sensor_entry['sensor_limit'] && $sensor_entry['sensor_custom'] == 'No') {
                                                                                                  $update = ['sensor_limit' => $high_limit];
                                                                                                  $updated = dbUpdate($update, 'sensors', '`sensor_id` = ?', [$sensor_entry['sensor_id']]);
                                                                                                  d_echo("( $updated updated )\n");
                                                                                      
                                                                                      
                                                                                      Severity: Major
                                                                                      Found in includes/discovery/functions.inc.php and 1 other location - About 3 hrs to fix
                                                                                      includes/discovery/functions.inc.php on lines 312..319

                                                                                      Duplicated Code

                                                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                                      Tuning

                                                                                      This issue has a mass of 156.

                                                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                                      Refactorings

                                                                                      Further Reading

                                                                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                                                                      Open

                                                                                              if ((string) $sensor_entry['sensor_limit_low'] != (string) $low_limit && $sensor_entry['sensor_custom'] == 'No') {
                                                                                                  $update = ['sensor_limit_low' => $low_limit];
                                                                                                  $updated = dbUpdate($update, 'sensors', '`sensor_id` = ?', [$sensor_entry['sensor_id']]);
                                                                                                  d_echo("( $updated updated )\n");
                                                                                      
                                                                                      
                                                                                      Severity: Major
                                                                                      Found in includes/discovery/functions.inc.php and 1 other location - About 3 hrs to fix
                                                                                      includes/discovery/functions.inc.php on lines 321..328

                                                                                      Duplicated Code

                                                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                                      Tuning

                                                                                      This issue has a mass of 156.

                                                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                                      Refactorings

                                                                                      Further Reading

                                                                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                                                                      Open

                                                                                              if ((string) $warn_limit != (string) $sensor_entry['sensor_limit_warn'] && $sensor_entry['sensor_custom'] == 'No') {
                                                                                                  $update = ['sensor_limit_warn' => $warn_limit];
                                                                                                  $updated = dbUpdate($update, 'sensors', '`sensor_id` = ?', [$sensor_entry['sensor_id']]);
                                                                                                  d_echo("( $updated updated )\n");
                                                                                      
                                                                                      
                                                                                      Severity: Major
                                                                                      Found in includes/discovery/functions.inc.php and 1 other location - About 3 hrs to fix
                                                                                      includes/discovery/functions.inc.php on lines 294..301

                                                                                      Duplicated Code

                                                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                                      Tuning

                                                                                      This issue has a mass of 156.

                                                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                                      Refactorings

                                                                                      Further Reading

                                                                                      Similar blocks of code found in 4 locations. Consider refactoring.
                                                                                      Open

                                                                                                  $update_data = [
                                                                                                      'entPhysicalIndex' => $entPhysicalIndex,
                                                                                                      'entPhysicalDescr' => $entPhysicalDescr,
                                                                                                      'entPhysicalClass' => $entPhysicalClass,
                                                                                                      'entPhysicalName' => $entPhysicalName,
                                                                                      Severity: Major
                                                                                      Found in includes/discovery/functions.inc.php and 3 other locations - About 40 mins to fix
                                                                                      includes/polling/applications/nvidia.inc.php on lines 52..70
                                                                                      includes/polling/applications/postgres.inc.php on lines 36..54
                                                                                      includes/polling/applications/postgres.inc.php on lines 73..91

                                                                                      Duplicated Code

                                                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                                      Tuning

                                                                                      This issue has a mass of 93.

                                                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                                      Refactorings

                                                                                      Further Reading

                                                                                      Avoid excessively long variable names like $entPhysicalContainedIn. Keep variable name length under 20.
                                                                                      Open

                                                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid excessively long variable names like $entPhysicalFirmwareRev. Keep variable name length under 20.
                                                                                      Open

                                                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid excessively long variable names like $entPhysicalVendorType. Keep variable name length under 20.
                                                                                      Open

                                                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid excessively long variable names like $entPhysicalIndex_measured. Keep variable name length under 20.
                                                                                      Open

                                                                                      function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr, $divisor = 1, $multiplier = 1, $low_limit = null, $low_warn_limit = null, $warn_limit = null, $high_limit = null, $current = null, $poller_type = 'snmp', $entPhysicalIndex = null, $entPhysicalIndex_measured = null, $user_func = null, $group = null, $rrd_type = 'GAUGE')
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid excessively long variable names like $entPhysicalParentRelPos. Keep variable name length under 20.
                                                                                      Open

                                                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid excessively long variable names like $entPhysicalSoftwareRev. Keep variable name length under 20.
                                                                                      Open

                                                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid excessively long variable names like $entPhysicalHardwareRev. Keep variable name length under 20.
                                                                                      Open

                                                                                      function discover_entity_physical(&$valid, $device, $entPhysicalIndex, $entPhysicalDescr, $entPhysicalClass, $entPhysicalName, $entPhysicalModelName, $entPhysicalSerialNum, $entPhysicalContainedIn, $entPhysicalMfgName, $entPhysicalParentRelPos, $entPhysicalVendorType, $entPhysicalHardwareRev, $entPhysicalFirmwareRev, $entPhysicalSoftwareRev, $entPhysicalIsFRU, $entPhysicalAlias, $entPhysicalAssetID, $ifIndex)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid excessively long variable names like $entPhysicalIndex_measured. Keep variable name length under 20.
                                                                                      Open

                                                                                                          $entPhysicalIndex_measured = isset($data['entPhysicalIndex_measured']) ? $data['entPhysicalIndex_measured'] : null;
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      LongVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, formal or local variable is declared with a long name.

                                                                                      Example

                                                                                      class Something {
                                                                                          protected $reallyLongIntName = -3; // VIOLATION - Field
                                                                                          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                                                                                              $otherReallyLongName = -5; // VIOLATION - Local
                                                                                              for ($interestingIntIndex = 0; // VIOLATION - For
                                                                                                   $interestingIntIndex < 10;
                                                                                                   $interestingIntIndex++ ) {
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#longvariable

                                                                                      Avoid variables with short names like $ip. Configured minimum length is 3.
                                                                                      Open

                                                                                              $ip = $hostname;
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ShortVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, local, or parameter has a very short name.

                                                                                      Example

                                                                                      class Something {
                                                                                          private $q = 15; // VIOLATION - Field
                                                                                          public static function main( array $as ) { // VIOLATION - Formal
                                                                                              $r = 20 + $this->q; // VIOLATION - Local
                                                                                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                                                                                  $r += $this->q;
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                                                                      Avoid variables with short names like $id. Configured minimum length is 3.
                                                                                      Open

                                                                                              $id = $data['id'];
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ShortVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, local, or parameter has a very short name.

                                                                                      Example

                                                                                      class Something {
                                                                                          private $q = 15; // VIOLATION - Field
                                                                                          public static function main( array $as ) { // VIOLATION - Formal
                                                                                              $r = 20 + $this->q; // VIOLATION - Local
                                                                                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                                                                                  $r += $this->q;
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                                                                      Avoid variables with short names like $os. Configured minimum length is 3.
                                                                                      Open

                                                                                      function sensors($types, $os, $valid, $pre_cache = [])
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ShortVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, local, or parameter has a very short name.

                                                                                      Example

                                                                                      class Something {
                                                                                          private $q = 15; // VIOLATION - Field
                                                                                          public static function main( array $as ) { // VIOLATION - Formal
                                                                                              $r = 20 + $this->q; // VIOLATION - Local
                                                                                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                                                                                  $r += $this->q;
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                                                                      Avoid variables with short names like $os. Configured minimum length is 3.
                                                                                      Open

                                                                                      function discovery_process(&$valid, $os, $sensor_class, $pre_cache)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ShortVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, local, or parameter has a very short name.

                                                                                      Example

                                                                                      class Something {
                                                                                          private $q = 15; // VIOLATION - Field
                                                                                          public static function main( array $as ) { // VIOLATION - Formal
                                                                                              $r = 20 + $this->q; // VIOLATION - Local
                                                                                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                                                                                  $r += $this->q;
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                                                                      Avoid variables with short names like $os. Configured minimum length is 3.
                                                                                      Open

                                                                                      function ignore_storage($os, $descr)
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ShortVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, local, or parameter has a very short name.

                                                                                      Example

                                                                                      class Something {
                                                                                          private $q = 15; // VIOLATION - Field
                                                                                          public static function main( array $as ) { // VIOLATION - Formal
                                                                                              $r = 20 + $this->q; // VIOLATION - Local
                                                                                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                                                                                  $r += $this->q;
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                                                                      Avoid variables with short names like $ip. Configured minimum length is 3.
                                                                                      Open

                                                                                      function find_device_id($name = '', $ip = '', $mac_address = '')
                                                                                      Severity: Minor
                                                                                      Found in includes/discovery/functions.inc.php by phpmd

                                                                                      ShortVariable

                                                                                      Since: 0.2

                                                                                      Detects when a field, local, or parameter has a very short name.

                                                                                      Example

                                                                                      class Something {
                                                                                          private $q = 15; // VIOLATION - Field
                                                                                          public static function main( array $as ) { // VIOLATION - Formal
                                                                                              $r = 20 + $this->q; // VIOLATION - Local
                                                                                              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                                                                                  $r += $this->q;
                                                                                              }
                                                                                          }
                                                                                      }

                                                                                      Source https://phpmd.org/rules/naming.html#shortvariable

                                                                                      There are no issues that match your filters.

                                                                                      Category
                                                                                      Status