librenms/librenms

View on GitHub
includes/discovery/services.inc.php

Summary

Maintainability
A
45 mins
Test Coverage

Avoid deeply nested control flow statements.
Open

                    if ($known_services[$tcp_port]) {
                        discover_service($device, $known_services[$tcp_port]);
                    }
Severity: Major
Found in includes/discovery/services.inc.php - About 45 mins to fix

    FIXME found
    Open

        (new ServiceTemplateController())->applyDeviceAll($device['device_id']); // FIXME applyAll() should not be on a controller
    Severity: Minor
    Found in includes/discovery/services.inc.php by fixme

    FIXME found
    Open

        // FIXME: use /etc/services?
    Severity: Minor
    Found in includes/discovery/services.inc.php by fixme

    There are no issues that match your filters.

    Category
    Status