librenms/librenms

View on GitHub
includes/html/collectd/functions.php

Summary

Maintainability
F
1 wk
Test Coverage

File functions.php has 673 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright (C) 2009  Bruno Prémont <bonbons AT linux-vserver.org>
 *
 * This program is free software; you can redistribute it and/or modify it under
Severity: Major
Found in includes/html/collectd/functions.php - About 1 day to fix

    Function collectd_draw_rrd has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
    Open

    function collectd_draw_rrd($host, $plugin, $type, $pinst = null, $tinst = null, $opts = [])
    {
        $timespan_def = null;
        $timespans = Config::get('timespan');
        if (! isset($opts['timespan'])) {
    Severity: Minor
    Found in includes/html/collectd/functions.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _rrd_info has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

    function _rrd_info($file)
    {
        $info = ['filename' => $file];
    
        $rrd = popen(RRDTOOL . ' info ' . escapeshellarg($file), 'r');
    Severity: Minor
    Found in includes/html/collectd/functions.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method collectd_draw_rrd has 133 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function collectd_draw_rrd($host, $plugin, $type, $pinst = null, $tinst = null, $opts = [])
    {
        $timespan_def = null;
        $timespans = Config::get('timespan');
        if (! isset($opts['timespan'])) {
    Severity: Major
    Found in includes/html/collectd/functions.php - About 5 hrs to fix

      Function collectd_draw_meta_stack has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

      function collectd_draw_meta_stack(&$opts, &$sources)
      {
          $timespan_def = null;
          $timespans = Config::get('timespan');
          if (! isset($opts['timespan'])) {
      Severity: Minor
      Found in includes/html/collectd/functions.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function collectd_draw_meta_line has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      function collectd_draw_meta_line(&$opts, &$sources)
      {
          $timespan_def = null;
          $timespans = Config::get('timespan');
          if (! isset($opts['timespan'])) {
      Severity: Minor
      Found in includes/html/collectd/functions.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method collectd_draw_meta_stack has 102 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function collectd_draw_meta_stack(&$opts, &$sources)
      {
          $timespan_def = null;
          $timespans = Config::get('timespan');
          if (! isset($opts['timespan'])) {
      Severity: Major
      Found in includes/html/collectd/functions.php - About 4 hrs to fix

        Method collectd_draw_meta_line has 87 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function collectd_draw_meta_line(&$opts, &$sources)
        {
            $timespan_def = null;
            $timespans = Config::get('timespan');
            if (! isset($opts['timespan'])) {
        Severity: Major
        Found in includes/html/collectd/functions.php - About 3 hrs to fix

          Function collectd_list_tinsts has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
          Open

          function collectd_list_tinsts($arg_host, $arg_plugin, $arg_pinst, $arg_type)
          {
              $tinsts = [];
              $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
              if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
          Severity: Minor
          Found in includes/html/collectd/functions.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function collectd_list_pinsts has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

          function collectd_list_pinsts($arg_host, $arg_plugin)
          {
              $pinsts = [];
              foreach (Config::get('datadirs') as $datadir) {
                  if (preg_match(REGEXP_HOST, $arg_host) && ($d = opendir($datadir . '/' . $arg_host))) {
          Severity: Minor
          Found in includes/html/collectd/functions.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function collectd_flush has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

          function collectd_flush($identifier)
          {
              if (! Config::get('collectd_sock')) {
                  return false;
              }
          Severity: Minor
          Found in includes/html/collectd/functions.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function collectd_list_types has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

          function collectd_list_types($arg_host, $arg_plugin, $arg_pinst)
          {
              $types = [];
              $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
              if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
          Severity: Minor
          Found in includes/html/collectd/functions.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function collectd_list_plugins has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

          function collectd_list_plugins($arg_host)
          {
              $plugins = [];
              foreach (Config::get('datadirs') as $datadir) {
                  if (preg_match(REGEXP_HOST, $arg_host) && ($d = @opendir($datadir . '/' . $arg_host))) {
          Severity: Minor
          Found in includes/html/collectd/functions.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method collectd_draw_generic has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function collectd_draw_generic($timespan, $host, $plugin, $type, $pinst = null, $tinst = null)
          {
              global $GraphDefs;
              $timespan_def = null;
              $timespans = Config::get('timespan');
          Severity: Major
          Found in includes/html/collectd/functions.php - About 2 hrs to fix

            Method _rrd_info has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function _rrd_info($file)
            {
                $info = ['filename' => $file];
            
                $rrd = popen(RRDTOOL . ' info ' . escapeshellarg($file), 'r');
            Severity: Minor
            Found in includes/html/collectd/functions.php - About 1 hr to fix

              Function collectd_draw_generic has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              function collectd_draw_generic($timespan, $host, $plugin, $type, $pinst = null, $tinst = null)
              {
                  global $GraphDefs;
                  $timespan_def = null;
                  $timespans = Config::get('timespan');
              Severity: Minor
              Found in includes/html/collectd/functions.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function collectd_list_hosts has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              function collectd_list_hosts()
              {
                  $hosts = [];
                  foreach (Config::get('datadirs') as $datadir) {
                      if ($d = @opendir($datadir)) {
              Severity: Minor
              Found in includes/html/collectd/functions.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method collectd_flush has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function collectd_flush($identifier)
              {
                  if (! Config::get('collectd_sock')) {
                      return false;
                  }
              Severity: Minor
              Found in includes/html/collectd/functions.php - About 1 hr to fix

                Method collectd_list_tinsts has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function collectd_list_tinsts($arg_host, $arg_plugin, $arg_pinst, $arg_type)
                {
                    $tinsts = [];
                    $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                    if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                Severity: Minor
                Found in includes/html/collectd/functions.php - About 1 hr to fix

                  Method collectd_draw_generic has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function collectd_draw_generic($timespan, $host, $plugin, $type, $pinst = null, $tinst = null)
                  Severity: Minor
                  Found in includes/html/collectd/functions.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        if (! isset($info['RRA']["$rra"])) {
                                            $info['RRA']["$rra"] = [];
                                        }
                    Severity: Major
                    Found in includes/html/collectd/functions.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          if (! isset($info['DS']["$ds"])) {
                                              $info['DS']["$ds"] = [];
                                          }
                      Severity: Major
                      Found in includes/html/collectd/functions.php - About 45 mins to fix

                        Method collectd_draw_rrd has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function collectd_draw_rrd($host, $plugin, $type, $pinst = null, $tinst = null, $opts = [])
                        Severity: Minor
                        Found in includes/html/collectd/functions.php - About 45 mins to fix

                          Consider simplifying this complex logical expression.
                          Open

                              if ($has_min && $has_max || $has_min && $has_avg || $has_avg && $has_max) {
                                  $n = 1;
                                  reset($rrdinfo['DS']);
                                  foreach ($rrdinfo['DS'] as $k => $v) {
                                      $graph[] = sprintf('LINE:%s_%s', $k, $has_min ? 'min' : 'avg');
                          Severity: Major
                          Found in includes/html/collectd/functions.php - About 40 mins to fix

                            Method collectd_identifier has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            function collectd_identifier($host, $plugin, $type, $pinst, $tinst)
                            Severity: Minor
                            Found in includes/html/collectd/functions.php - About 35 mins to fix

                              Function collectd_identifier has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function collectd_identifier($host, $plugin, $type, $pinst, $tinst)
                              {
                                  $rrd_realpath = null;
                                  $orig_identifier = sprintf('%s/%s%s%s/%s%s%s', $host, $plugin, strlen($pinst) ? '-' : '', $pinst, $type, strlen($tinst) ? '-' : '', $tinst);
                                  $identifier = null;
                              Severity: Minor
                              Found in includes/html/collectd/functions.php - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              The function collectd_draw_meta_line() has 109 lines of code. Current threshold is set to 100. Avoid really long methods.
                              Open

                              function collectd_draw_meta_line(&$opts, &$sources)
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              The function collectd_draw_meta_stack() has 129 lines of code. Current threshold is set to 100. Avoid really long methods.
                              Open

                              function collectd_draw_meta_stack(&$opts, &$sources)
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              The function collectd_flush() has an NPath complexity of 588. The configured NPath complexity threshold is 200.
                              Open

                              function collectd_flush($identifier)
                              {
                                  if (! Config::get('collectd_sock')) {
                                      return false;
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The function collectd_draw_meta_stack() has an NPath complexity of 172800. The configured NPath complexity threshold is 200.
                              Open

                              function collectd_draw_meta_stack(&$opts, &$sources)
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The function collectd_draw_rrd() has an NPath complexity of 12768768000. The configured NPath complexity threshold is 200.
                              Open

                              function collectd_draw_rrd($host, $plugin, $type, $pinst = null, $tinst = null, $opts = [])
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The function collectd_draw_rrd() has 161 lines of code. Current threshold is set to 100. Avoid really long methods.
                              Open

                              function collectd_draw_rrd($host, $plugin, $type, $pinst = null, $tinst = null, $opts = [])
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              The function collectd_draw_generic() has an NPath complexity of 480. The configured NPath complexity threshold is 200.
                              Open

                              function collectd_draw_generic($timespan, $host, $plugin, $type, $pinst = null, $tinst = null)
                              {
                                  global $GraphDefs;
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The function collectd_draw_meta_line() has an NPath complexity of 86400. The configured NPath complexity threshold is 200.
                              Open

                              function collectd_draw_meta_line(&$opts, &$sources)
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              NPathComplexity

                              Since: 0.1

                              The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                              Example

                              class Foo {
                                  function bar() {
                                      // lots of complicated code
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#npathcomplexity

                              The function collectd_list_types() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_list_types($arg_host, $arg_plugin, $arg_pinst)
                              {
                                  $types = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function collectd_draw_meta_stack() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_draw_meta_stack(&$opts, &$sources)
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function _rrd_info() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                              Open

                              function _rrd_info($file)
                              {
                                  $info = ['filename' => $file];
                              
                                  $rrd = popen(RRDTOOL . ' info ' . escapeshellarg($file), 'r');
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function collectd_flush() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_flush($identifier)
                              {
                                  if (! Config::get('collectd_sock')) {
                                      return false;
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function collectd_draw_rrd() has a Cyclomatic Complexity of 52. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_draw_rrd($host, $plugin, $type, $pinst = null, $tinst = null, $opts = [])
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function collectd_draw_meta_line() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_draw_meta_line(&$opts, &$sources)
                              {
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                                  if (! isset($opts['timespan'])) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function collectd_list_pinsts() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_list_pinsts($arg_host, $arg_plugin)
                              {
                                  $pinsts = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function collectd_list_tinsts() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_list_tinsts($arg_host, $arg_plugin, $arg_pinst, $arg_type)
                              {
                                  $tinsts = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The function collectd_draw_generic() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                              Open

                              function collectd_draw_generic($timespan, $host, $plugin, $type, $pinst = null, $tinst = null)
                              {
                                  global $GraphDefs;
                                  $timespan_def = null;
                                  $timespans = Config::get('timespan');
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              CyclomaticComplexity

                              Since: 0.1

                              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                              Example

                              // Cyclomatic Complexity = 11
                              class Foo {
                              1   public function example() {
                              2       if ($a == $b) {
                              3           if ($a1 == $b1) {
                                              fiddle();
                              4           } elseif ($a2 == $b2) {
                                              fiddle();
                                          } else {
                                              fiddle();
                                          }
                              5       } elseif ($c == $d) {
                              6           while ($c == $d) {
                                              fiddle();
                                          }
                              7        } elseif ($e == $f) {
                              8           for ($n = 0; $n < $h; $n++) {
                                              fiddle();
                                          }
                                      } else {
                                          switch ($z) {
                              9               case 1:
                                                  fiddle();
                                                  break;
                              10              case 2:
                                                  fiddle();
                                                  break;
                              11              case 3:
                                                  fiddle();
                                                  break;
                                              default:
                                                  fiddle();
                                                  break;
                                          }
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                              The method rrd_get_color has a boolean flag argument $line, which is a certain sign of a Single Responsibility Principle violation.
                              Open

                              function rrd_get_color($code, $line = true)
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              BooleanArgumentFlag

                              Since: 1.4.0

                              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                              Example

                              class Foo {
                                  public function bar($flag = true) {
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                              Remove error control operator '@' on line 228.
                              Open

                              function collectd_list_tinsts($arg_host, $arg_plugin, $arg_pinst, $arg_type)
                              {
                                  $tinsts = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ErrorControlOperator

                              Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                              Example

                              function foo($filePath) {
                                  $file = @fopen($filPath); // hides exceptions
                                  $key = @$array[$notExistingKey]; // assigns null to $key
                              }

                              Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                              Remove error control operator '@' on line 184.
                              Open

                              function collectd_list_types($arg_host, $arg_plugin, $arg_pinst)
                              {
                                  $types = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ErrorControlOperator

                              Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                              Example

                              function foo($filePath) {
                                  $file = @fopen($filPath); // hides exceptions
                                  $key = @$array[$notExistingKey]; // assigns null to $key
                              }

                              Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                              Remove error control operator '@' on line 78.
                              Open

                              function collectd_list_hosts()
                              {
                                  $hosts = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if ($d = @opendir($datadir)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ErrorControlOperator

                              Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                              Example

                              function foo($filePath) {
                                  $file = @fopen($filPath); // hides exceptions
                                  $key = @$array[$notExistingKey]; // assigns null to $key
                              }

                              Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                              Remove error control operator '@' on line 105.
                              Open

                              function collectd_list_plugins($arg_host)
                              {
                                  $plugins = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = @opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ErrorControlOperator

                              Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                              Example

                              function foo($filePath) {
                                  $file = @fopen($filPath); // hides exceptions
                                  $key = @$array[$notExistingKey]; // assigns null to $key
                              }

                              Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                              Remove error control operator '@' on line 316.
                              Open

                              function collectd_flush($identifier)
                              {
                                  if (! Config::get('collectd_sock')) {
                                      return false;
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ErrorControlOperator

                              Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

                              Example

                              function foo($filePath) {
                                  $file = @fopen($filPath); // hides exceptions
                                  $key = @$array[$notExistingKey]; // assigns null to $key
                              }

                              Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

                              The method read_var uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                      } else {
                                          return $array[$name];
                                      }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_list_pinsts uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                                  } else {
                                                      $plugin = $dent;
                                                      $pinst = '';
                                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_list_tinsts uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                                  } else {
                                                      $type = $dent;
                                                      $tinst = '';
                                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_flush uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                  } else {
                                      error_log(sprintf('graph.php: Failed to open unix-socket to collectd: %d: %s', $u_errno, $u_errmsg));
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_draw_meta_stack uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                      } else {
                                          $line_color = new CollectdColor('random');
                                      }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_flush uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                      } else {
                                          $cmd .= sprintf(' identifier="%s"', $identifier);
                                      }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '316', column '9').
                              Open

                              function collectd_flush($identifier)
                              {
                                  if (! Config::get('collectd_sock')) {
                                      return false;
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method rrd_strip_quotes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                  } else {
                                      return $str;
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '108', column '25').
                              Open

                              function collectd_list_plugins($arg_host)
                              {
                                  $plugins = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = @opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method read_var uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                  } else {
                                      return $default;
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '61', column '14').
                              Open

                              function collectd_compare_host($a, $b)
                              {
                                  $ea = explode('.', $a);
                                  $eb = explode('.', $b);
                                  $i = (count($ea) - 1);
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method collectd_draw_rrd uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                  } else {
                                      foreach ($timespans as &$ts) {
                                          if ($ts['name'] == $opts['timespan']) {
                                              $timespan_def = $ts;
                                          }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_draw_meta_line uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                      } else {
                                          $line_color = new CollectdColor('random');
                                      }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_list_types uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                                  } else {
                                                      $types[] = $dent;
                                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '232', column '25').
                              Open

                              function collectd_list_tinsts($arg_host, $arg_plugin, $arg_pinst, $arg_type)
                              {
                                  $tinsts = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method collectd_draw_rrd uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                          } else {
                                              $rrdinfo = null;
                                          }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '78', column '13').
                              Open

                              function collectd_list_hosts()
                              {
                                  $hosts = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if ($d = @opendir($datadir)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method collectd_list_hosts uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                      } else {
                                          error_log('Failed to open datadir: ' . $datadir);
                                      }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              The method collectd_list_plugins uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                                  } else {
                                                      $plugins[] = $dent;
                                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '228', column '52').
                              Open

                              function collectd_list_tinsts($arg_host, $arg_plugin, $arg_pinst, $arg_type)
                              {
                                  $tinsts = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method collectd_identifier uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                  } else {
                                      return $identifier;
                                  }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '137', column '52').
                              Open

                              function collectd_list_pinsts($arg_host, $arg_plugin)
                              {
                                  $pinsts = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              Avoid assigning values to variables in if clauses and the like (line '188', column '25').
                              Open

                              function collectd_list_types($arg_host, $arg_plugin, $arg_pinst)
                              {
                                  $types = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method collectd_draw_meta_line uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                  } else {
                                      foreach ($timespans as &$ts) {
                                          if ($ts['name'] == $opts['timespan']) {
                                              $timespan_def = $ts;
                                          }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid assigning values to variables in if clauses and the like (line '105', column '52').
                              Open

                              function collectd_list_plugins($arg_host)
                              {
                                  $plugins = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = @opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              Avoid assigning values to variables in if clauses and the like (line '140', column '25').
                              Open

                              function collectd_list_pinsts($arg_host, $arg_plugin)
                              {
                                  $pinsts = [];
                                  foreach (Config::get('datadirs') as $datadir) {
                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              Avoid assigning values to variables in if clauses and the like (line '184', column '52').
                              Open

                              function collectd_list_types($arg_host, $arg_plugin, $arg_pinst)
                              {
                                  $types = [];
                                  $my_plugin = $arg_plugin . (strlen($arg_pinst) ? '-' . $arg_pinst : '');
                                  if (! preg_match(REGEXP_PLUGIN, $my_plugin)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              IfStatementAssignment

                              Since: 2.7.0

                              Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($foo = 'bar') { // possible typo
                                          // ...
                                      }
                                      if ($baz = 0) { // always false
                                          // ...
                                      }
                                  }
                              }

                              Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                              The method collectd_draw_meta_stack uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
                              Open

                                  } else {
                                      foreach ($timespans as &$ts) {
                                          if ($ts['name'] == $opts['timespan']) {
                                              $timespan_def = $ts;
                                          }
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ElseExpression

                              Since: 1.4.0

                              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

                              Example

                              class Foo
                              {
                                  public function bar($flag)
                                  {
                                      if ($flag) {
                                          // one branch
                                      } else {
                                          // another branch
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/cleancode.html#elseexpression

                              Avoid unused local variables such as '$timespan_def'.
                              Open

                                  $timespan_def = null;
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              UnusedLocalVariable

                              Since: 0.2

                              Detects when a local variable is declared and/or assigned, but not used.

                              Example

                              class Foo {
                                  public function doSomething()
                                  {
                                      $i = 5; // Unused
                                  }
                              }

                              Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                              Avoid unused local variables such as '$timespan_def'.
                              Open

                                  $timespan_def = null;
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              UnusedLocalVariable

                              Since: 0.2

                              Detects when a local variable is declared and/or assigned, but not used.

                              Example

                              class Foo {
                                  public function doSomething()
                                  {
                                      $i = 5; // Unused
                                  }
                              }

                              Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                              Avoid unused local variables such as '$timespan_def'.
                              Open

                                  $timespan_def = null;
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              UnusedLocalVariable

                              Since: 0.2

                              Detects when a local variable is declared and/or assigned, but not used.

                              Example

                              class Foo {
                                  public function doSomething()
                                  {
                                      $i = 5; // Unused
                                  }
                              }

                              Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          if (strncmp($key, 'ds[', 3) == 0) {
                                              // DS definition
                                              $p = strpos($key, ']');
                                              $ds = substr($key, 3, $p - 3);
                                              if (! isset($info['DS'])) {
                              Severity: Major
                              Found in includes/html/collectd/functions.php and 1 other location - About 4 hrs to fix
                              includes/html/collectd/functions.php on lines 403..420

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 177.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          } elseif (strncmp($key, 'rra[', 4) == 0) {
                                              // RRD definition
                                              $p = strpos($key, ']');
                                              $rra = substr($key, 4, $p - 4);
                                              if (! isset($info['RRA'])) {
                              Severity: Major
                              Found in includes/html/collectd/functions.php and 1 other location - About 4 hrs to fix
                              includes/html/collectd/functions.php on lines 386..422

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 177.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if (! (isset($opts['tinylegend']) && $opts['tinylegend'])) {
                                          $cmd[] = 'GPRINT:' . $inst_name . '_min:MIN:' . $number_format . '';
                                          $cmd[] = 'GPRINT:' . $inst_name . '_avg:AVERAGE:' . $number_format . '';
                                          $cmd[] = 'GPRINT:' . $inst_name . '_max:MAX:' . $number_format . '';
                                          $cmd[] = 'GPRINT:' . $inst_name . '_avg:LAST:' . $number_format . '\\l';
                              Severity: Major
                              Found in includes/html/collectd/functions.php and 1 other location - About 2 hrs to fix
                              includes/html/collectd/functions.php on lines 820..825

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 121.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if (! (isset($opts['tinylegend']) && $opts['tinylegend'])) {
                                          $cmd[] = 'GPRINT:' . $inst_name . '_avg:LAST:' . $number_format . '';
                                          $cmd[] = 'GPRINT:' . $inst_name . '_avg:AVERAGE:' . $number_format . '';
                                          $cmd[] = 'GPRINT:' . $inst_name . '_min:MIN:' . $number_format . '';
                                          $cmd[] = 'GPRINT:' . $inst_name . '_max:MAX:' . $number_format . '\\l';
                              Severity: Major
                              Found in includes/html/collectd/functions.php and 1 other location - About 2 hrs to fix
                              includes/html/collectd/functions.php on lines 937..942

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 121.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 24 and the first side effect is on line 19.
                              Open

                              <?php

                              Avoid variables with short names like $r. Configured minimum length is 3.
                              Open

                                      $r = fwrite($socket, $cmd, strlen($cmd));
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ds. Configured minimum length is 3.
                              Open

                                              $ds = substr($key, 3, $p - 3);
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ts. Configured minimum length is 3.
                              Open

                                      foreach ($timespans as &$ts) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $a. Configured minimum length is 3.
                              Open

                              function collectd_compare_host($a, $b)
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $d. Configured minimum length is 3.
                              Open

                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = @opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $j. Configured minimum length is 3.
                              Open

                                  $j = (count($eb) - 1);
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $d. Configured minimum length is 3.
                              Open

                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = opendir($datadir . '/' . $arg_host))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ts. Configured minimum length is 3.
                              Open

                                  foreach ($timespans as &$ts) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ea. Configured minimum length is 3.
                              Open

                                  $ea = explode('.', $a);
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $i. Configured minimum length is 3.
                              Open

                                                  if ($i = strpos($dent, '-')) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $b. Configured minimum length is 3.
                              Open

                              function collectd_compare_host($a, $b)
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $i. Configured minimum length is 3.
                              Open

                                  $i = (count($ea) - 1);
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $r. Configured minimum length is 3.
                              Open

                                      if (($r = strcmp($ea[$i--], $eb[$j--])) != 0) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $d. Configured minimum length is 3.
                              Open

                                      if ($d = @opendir($datadir)) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $d. Configured minimum length is 3.
                              Open

                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = @opendir($datadir . '/' . $arg_host . '/' . $my_plugin))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $i. Configured minimum length is 3.
                              Open

                                                  if ($i = strpos($dent, '-')) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $p. Configured minimum length is 3.
                              Open

                                          $p = strpos($s, '=');
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $n. Configured minimum length is 3.
                              Open

                                      $n = 1;
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ds. Configured minimum length is 3.
                              Open

                                      $ds = isset($inst_data['ds']) ? $inst_data['ds'] : 'value';
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $i. Configured minimum length is 3.
                              Open

                                                  if ($i = strpos($dent, '-')) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $s. Configured minimum length is 3.
                              Open

                                      while (($s = fgets($rrd)) !== false) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ts. Configured minimum length is 3.
                              Open

                                      foreach ($timespans as &$ts) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ts. Configured minimum length is 3.
                              Open

                                      foreach ($timespans as &$ts) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $ds. Configured minimum length is 3.
                              Open

                                      $ds = isset($inst_data['ds']) ? $inst_data['ds'] : 'value';
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $eb. Configured minimum length is 3.
                              Open

                                  $eb = explode('.', $b);
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $i. Configured minimum length is 3.
                              Open

                                                  if ($i = strpos($dent, '-')) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $d. Configured minimum length is 3.
                              Open

                                      if (preg_match(REGEXP_HOST, $arg_host) && ($d = @opendir($datadir . '/' . $arg_host . '/' . $my_plugin))) {
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              Avoid variables with short names like $n. Configured minimum length is 3.
                              Open

                                      $n = (int) $resp;
                              Severity: Minor
                              Found in includes/html/collectd/functions.php by phpmd

                              ShortVariable

                              Since: 0.2

                              Detects when a field, local, or parameter has a very short name.

                              Example

                              class Something {
                                  private $q = 15; // VIOLATION - Field
                                  public static function main( array $as ) { // VIOLATION - Formal
                                      $r = 20 + $this->q; // VIOLATION - Local
                                      for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                          $r += $this->q;
                                      }
                                  }
                              }

                              Source https://phpmd.org/rules/naming.html#shortvariable

                              There are no issues that match your filters.

                              Category
                              Status