Sign upLogin

librenms/librenms

View on GitHub
Star
includes/html/pages/bill/actions.inc.php

Summary

Maintainability
D
2 days
Test Coverage

Avoid deeply nested control flow statements.
Open

                if ($_POST['bill_cdr_type'] == 'Mbps') {
                    $multiplier = (1 * \LibreNMS\Config::get('billing.base') * \LibreNMS\Config::get('billing.base'));
                }
Severity: Major
Found in includes/html/pages/bill/actions.inc.php - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    if ($_POST['bill_quota_type'] == 'TB') {
                    $multiplier = (1 * \LibreNMS\Config::get('billing.base') * \LibreNMS\Config::get('billing.base') * \LibreNMS\Config::get('billing.base'));
                }
    Severity: Major
    Found in includes/html/pages/bill/actions.inc.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if ($_POST['bill_cdr_type'] == 'Kbps') {
                    $multiplier = (1 * \LibreNMS\Config::get('billing.base'));
                }
      Severity: Major
      Found in includes/html/pages/bill/actions.inc.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if ($_POST['bill_cdr_type'] == 'Gbps') {
                    $multiplier = (1 * \LibreNMS\Config::get('billing.base') * \LibreNMS\Config::get('billing.base') * \LibreNMS\Config::get('billing.base'));
                }
        Severity: Major
        Found in includes/html/pages/bill/actions.inc.php - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                          if ($_POST['bill_quota_type'] == 'GB') {
                    $multiplier = (1 * \LibreNMS\Config::get('billing.base') * \LibreNMS\Config::get('billing.base'));
                }
          Severity: Major
          Found in includes/html/pages/bill/actions.inc.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            if ($_POST['bill_quota_type'] == 'MB') {
                    $multiplier = (1 * \LibreNMS\Config::get('billing.base'));
                }
            Severity: Major
            Found in includes/html/pages/bill/actions.inc.php - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (isset($_POST['bill_quota']) or isset($_POST['bill_cdr'])) {
        if ($_POST['bill_type'] == 'quota') {
            if (isset($_POST['bill_quota_type'])) {
                if ($_POST['bill_quota_type'] == 'MB') {
                    $multiplier = (1 * \LibreNMS\Config::get('billing.base'));
              Severity: Major
              Found in includes/html/pages/bill/actions.inc.php and 1 other location - About 2 days to fix
              includes/html/pages/bills.inc.php on lines 13..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 410.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status