librenms/librenms

File showconfig.inc.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

// FIXME svn stuff still using optc etc, won't work, needs updating!
use LibreNMS\Config;
use Symfony\Component\Process\Process;

Avoid deeply nested control flow statements.

Open

                if ($lines[$i][0] == '#') {
                    unset($lines[$i]);
                }

FIXME found

Open

// FIXME svn stuff still using optc etc, won't work, needs updating!

• Exclude checks
  • Disable engine
  • Disable check

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (in_array($vars['rev'], $revlist)) {
                $process = new Process(['git', 'diff', $vars['rev'] . '^', $vars['rev'], $rancid_file], $rancid_path);
                $process->run();
                $diff = $process->getOutput();
                if (! $diff) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (function_exists('svn_log') && in_array($vars['rev'], $revlist)) {
                [$diff, $errors] = svn_diff($rancid_file, $vars['rev'] - 1, $rancid_file, $vars['rev']);
                if (! $diff) {
                    $text = 'No Difference';
                } else {

• Read up
  Read up