Sign upLogin

lighttroupe/luz

View on GitHub
Star
gui/gui_director_menu.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method on_key_press has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def on_key_press(key)
        if key.control?
            case key
            when 'n'
                add_new_director!
Severity: Minor
Found in gui/gui_director_menu.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method choose_column_count has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def choose_column_count
        if @grid.count > 49
            8
        elsif @grid.count > 36
            7
Severity: Minor
Found in gui/gui_director_menu.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

        self << @cancel_button = GuiButton.new.set(:scale_x => 0.05, :scale_y => 0.06, :offset_x => 0.475, :offset_y => 0.47, :background_image => $engine.load_image('images/buttons/director-view-close.png'), :background_image_hover => $engine.load_image('images/buttons/director-view-close-hover.png'), :background_image_click => $engine.load_image('images/buttons/director-view-close-click.png'))
Severity: Major
Found in gui/gui_director_menu.rb and 13 other locations - About 20 mins to fix
gui/gui_beat_monitor.rb on lines 31..31
gui/gui_beat_monitor.rb on lines 34..34
gui/gui_default.rb on lines 253..253
gui/gui_default.rb on lines 259..259
gui/gui_default.rb on lines 280..280
gui/gui_director_menu.rb on lines 24..24
gui/gui_director_menu.rb on lines 30..30
gui/gui_directory_dialog.rb on lines 22..22
gui/gui_file_dialog.rb on lines 93..93
gui/gui_main_menu.rb on lines 13..13
gui/gui_main_menu.rb on lines 16..16
gui/gui_main_menu.rb on lines 39..39
gui/gui_main_menu.rb on lines 50..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

        self << @project_effects_button = GuiButton.new.set(:scale_x => 0.05, :scale_y => 0.06, :offset_x => 0.475, :offset_y => -0.47, :background_image => $engine.load_image('images/buttons/project-effects.png'), :background_image_hover => $engine.load_image('images/buttons/project-effects-hover.png'), :background_image_click => $engine.load_image('images/buttons/project-effects-click.png'))
Severity: Major
Found in gui/gui_director_menu.rb and 13 other locations - About 20 mins to fix
gui/gui_beat_monitor.rb on lines 31..31
gui/gui_beat_monitor.rb on lines 34..34
gui/gui_default.rb on lines 253..253
gui/gui_default.rb on lines 259..259
gui/gui_default.rb on lines 280..280
gui/gui_director_menu.rb on lines 30..30
gui/gui_director_menu.rb on lines 35..35
gui/gui_directory_dialog.rb on lines 22..22
gui/gui_file_dialog.rb on lines 93..93
gui/gui_main_menu.rb on lines 13..13
gui/gui_main_menu.rb on lines 16..16
gui/gui_main_menu.rb on lines 39..39
gui/gui_main_menu.rb on lines 50..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

        self << @add_button = GuiButton.new.set(:scale_x => 0.05, :scale_y => 0.06, :offset_x => -0.475, :offset_y => -0.47, :background_image => $engine.load_image('images/buttons/new-director.png'), :background_image_hover => $engine.load_image('images/buttons/new-director-hover.png'), :background_image_click => $engine.load_image('images/buttons/new-director-click.png'))
Severity: Major
Found in gui/gui_director_menu.rb and 13 other locations - About 20 mins to fix
gui/gui_beat_monitor.rb on lines 31..31
gui/gui_beat_monitor.rb on lines 34..34
gui/gui_default.rb on lines 253..253
gui/gui_default.rb on lines 259..259
gui/gui_default.rb on lines 280..280
gui/gui_director_menu.rb on lines 24..24
gui/gui_director_menu.rb on lines 35..35
gui/gui_directory_dialog.rb on lines 22..22
gui/gui_file_dialog.rb on lines 93..93
gui/gui_main_menu.rb on lines 13..13
gui/gui_main_menu.rb on lines 16..16
gui/gui_main_menu.rb on lines 39..39
gui/gui_main_menu.rb on lines 50..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status