Sign upLogin

lighttroupe/luz

View on GitHub
Star
gui/gui_user_object_editor.rb

Summary

Maintainability
C
1 day
Test Coverage

Class GuiUserObjectEditor has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class GuiUserObjectEditor < GuiWindow
    attr_accessor :pointer

    BACKGROUND_COLOR = [0,0,0,0.95]
Severity: Minor
Found in gui/gui_user_object_editor.rb - About 2 hrs to fix

    Method on_key_press has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_key_press(key)
        if key.control?
            if key == 'd'
                clone_selected
            elsif key == 'e'
    Severity: Minor
    Found in gui/gui_user_object_editor.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method gui_build_editor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def gui_build_editor
        if @user_object.respond_to? :effects
            box = GuiBox.new

            # Effects list
    Severity: Minor
    Found in gui/gui_user_object_editor.rb - About 1 hr to fix

      Method on_key_press has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def on_key_press(key)
        if key.control?
            if key == 'd'
                clone_selected
            elsif key == 'e'
      Severity: Minor
      Found in gui/gui_user_object_editor.rb - About 1 hr to fix

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                self << (@close_button=GuiButton.new.set(:scale_x => 0.15, :scale_y => 0.07, :offset_x => 0.0, :offset_y => -0.5 + 0.035, :background_image => $engine.load_image('images/buttons/close.png'), :background_image_hover => $engine.load_image('images/buttons/close-hover.png')))
        Severity: Minor
        Found in gui/gui_user_object_editor.rb and 5 other locations - About 15 mins to fix
        gui/gui_add_window.rb on lines 137..137
        gui/gui_add_window.rb on lines 145..145
        gui/gui_directory_dialog.rb on lines 13..13
        gui/gui_file_dialog.rb on lines 83..83
        gui/gui_file_dialog.rb on lines 90..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status