Sign upLogin

lighttroupe/luz

View on GitHub
Star
utils/drawing/drawing_shader_snippets.rb

Summary

Maintainability
D
2 days
Test Coverage

Method with_compiled_shader has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def with_compiled_shader
        return yield if $fragment_shader_snippet_stack.empty? and $vertex_shader_snippet_stack.empty?
        $next_texture_number ||= 0

        fragment_shader_source = $fragment_shader_snippet_cache[$fragment_shader_snippet_stack]
Severity: Minor
Found in utils/drawing/drawing_shader_snippets.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method with_compiled_shader has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def with_compiled_shader
        return yield if $fragment_shader_snippet_stack.empty? and $vertex_shader_snippet_stack.empty?
        $next_texture_number ||= 0

        fragment_shader_source = $fragment_shader_snippet_cache[$fragment_shader_snippet_stack]
Severity: Minor
Found in utils/drawing/drawing_shader_snippets.rb - About 1 hr to fix

    Method join_fragment_shader_snippet_stack has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def join_fragment_shader_snippet_stack(uniforms, snippets, objects)
        return FRAGMENT_SHADER_STUB if snippets.empty?

        #
        # Source code for uniforms declarations at top of shader scripts
    Severity: Minor
    Found in utils/drawing/drawing_shader_snippets.rb - About 1 hr to fix

      Method join_vertex_shader_snippet_stack has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def join_vertex_shader_snippet_stack(uniforms, snippets, objects)
        return VERTEX_SHADER_STUB if snippets.empty?

        #
        # Source code for uniforms declarations at top of shader scripts
      Severity: Minor
      Found in utils/drawing/drawing_shader_snippets.rb - About 1 hr to fix

        Method join_fragment_shader_snippet_stack has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def join_fragment_shader_snippet_stack(uniforms, snippets, objects)
        return FRAGMENT_SHADER_STUB if snippets.empty?

        #
        # Source code for uniforms declarations at top of shader scripts
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method with_vertex_shader_snippet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def with_vertex_shader_snippet(snippet, object)
        return yield unless snippet         # allow nil

        index = $vertex_shader_object_stack.count
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method with_fragment_shader_snippet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def with_fragment_shader_snippet(snippet, object)
        return yield unless snippet        # allow nil

        index = $fragment_shader_object_stack.count
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method join_vertex_shader_snippet_stack has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def join_vertex_shader_snippet_stack(uniforms, snippets, objects)
        return VERTEX_SHADER_STUB if snippets.empty?

        #
        # Source code for uniforms declarations at top of shader scripts
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def with_fragment_shader_snippet(snippet, object)
        return yield unless snippet        # allow nil

        index = $fragment_shader_object_stack.count
        Severity: Major
        Found in utils/drawing/drawing_shader_snippets.rb and 1 other location - About 1 hr to fix
        utils/drawing/drawing_shader_snippets.rb on lines 81..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def with_vertex_shader_snippet(snippet, object)
        return yield unless snippet         # allow nil

        index = $vertex_shader_object_stack.count
        Severity: Major
        Found in utils/drawing/drawing_shader_snippets.rb and 1 other location - About 1 hr to fix
        utils/drawing/drawing_shader_snippets.rb on lines 54..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                snippets_with_variables = snippets.collect_with_index { |snippet, index|
            object = objects[index]
            object.settings.each { |setting|
                if setting.shader?
                    # TODO: improve find-and-replace
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb and 1 other location - About 55 mins to fix
        utils/drawing/drawing_shader_snippets.rb on lines 215..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                snippets_with_variables = snippets.collect_with_index { |snippet, index|
            object = objects[index]
            object.settings.each { |setting|
                if setting.shader?
                    # TODO: improve find-and-replace
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb and 1 other location - About 55 mins to fix
        utils/drawing/drawing_shader_snippets.rb on lines 275..288

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                uniforms = uniforms.collect { |name_and_value|
            case name_and_value[1]
            when Float
                "uniform float #{name_and_value[0]};"
            when Integer
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb and 1 other location - About 40 mins to fix
        utils/drawing/drawing_shader_snippets.rb on lines 185..194

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                uniforms = uniforms.collect { |name_and_value|
            case name_and_value[1]
            when Float
                "uniform float #{name_and_value[0]};"
            when Integer
        Severity: Minor
        Found in utils/drawing/drawing_shader_snippets.rb and 1 other location - About 40 mins to fix
        utils/drawing/drawing_shader_snippets.rb on lines 248..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status