limpygnome/build-tv

View on GitHub

Showing 87 of 87 total issues

Method execFloat has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public static Float execFloat(String[] commands, long processTimeout, boolean mockingEnabled)
    {
        String commandsStr = StringUtils.join(commands);

        if (mockingEnabled && isDevEnvironment())

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void run()
    {
        // Wait for services to startup...
        controller.waitForState(ControllerState.RUNNING);

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setup has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setup: function(snowImage, numberOfFlakes, sizeMin, sizeMax)
    {
        if (snowImage != null)
        {
            this.snowImage = snowImage;

    Method update has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public JenkinsHostUpdateResult update(RestClient restClient)
        {
            try
            {
                boolean jobsEmpty = jobs.isEmpty();

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  try
                  {
                      $.getJSON(buildTvController.buildTvServiceUrl, function(data) {
      
                          buildTvController.pollHandle(data);
      src/clients/launcher-client/src/main/resources/website/content/notifications/notificationController.js on lines 43..56

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              try
              {
                  $.getJSON(notificationController.notificationsServiceUrl, function(data){
      
                      notificationController.handlePollData(data);
      src/clients/launcher-client/src/main/resources/website/content/build-tv/buildTvController.js on lines 39..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 86.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method execFloat has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static Float execFloat(String[] commands, long processTimeout, boolean mockingEnabled)
          {
              String commandsStr = StringUtils.join(commands);
      
              if (mockingEnabled && isDevEnvironment())

        Function updateField has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

            updateField: function(stockData, item, target, preSymbol, postSymbol)
            {
                var isPreSymbol = (preSymbol != null && preSymbol.length > 0);
                var isPostSymbol = (postSymbol != null && postSymbol.length > 0);
        
        

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method handle has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
            public void handle(HttpExchange httpExchange) throws IOException
            {
                Map<String, String> params = UrlUtil.parseQueryParams(httpExchange);
        
        

          Method updateNotificationFromJenkinsResult has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private void updateNotificationFromJenkinsResult(JenkinsHostUpdateResult hostsResult)
              {
                  // TODO: probably shouldn't have magic values here, clean it up eventually using config with fallback default values
                  LedPattern currentLedPattern = hostsResult.getLedPattern();
          
          

            CallbackModule has 21 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class CallbackModule(object):
            
                def on_any(self, *args, **kwargs):
                    pass
            
            
            Severity: Minor
            Found in deploy/plugins/human_log.py - About 2 hrs to fix

              Function setup has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  setup: function(snowImage, numberOfFlakes, sizeMin, sizeMax)
                  {
                      if (snowImage != null)
                      {
                          this.snowImage = snowImage;

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method exec has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static Process exec(String[] commands, long processTimeout, boolean mockingEnabled)
                  {
                      String commandsStr = StringUtils.join(commands, ",");
              
                      if (mockingEnabled && isDevEnvironment())

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @Override
                  public void run()
                  {
                      // Wait for services to startup...
                      controller.waitForState(ControllerState.RUNNING);

                Method handle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @Override
                    public void handle(HttpExchange httpExchange) throws IOException
                    {
                        // Create request/response objects
                        RestRequest restRequest;

                  Method updateNotificationFromJenkinsResult has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private void updateNotificationFromJenkinsResult(JenkinsHostUpdateResult hostsResult)
                      {
                          // TODO: probably shouldn't have magic values here, clean it up eventually using config with fallback default values
                          LedPattern currentLedPattern = hostsResult.getLedPattern();
                  
                  

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method handleSetLed has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private boolean handleSetLed(RestRequest restRequest, RestResponse restResponse)
                      {
                          // Check required data elements present
                          String source = (String) restRequest.getJsonElement(new String[]{ "source" });
                          String pattern = (String) restRequest.getJsonElement(new String[]{ "pattern" });

                    Function handlePollData has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        handlePollData: function(notification)
                        {
                            if (notification != null && notification.timestamp != null)
                            {
                                var currentTimestamp = dashboardUtils.currentTime();

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function updateField has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        updateField: function(stockData, item, target, preSymbol, postSymbol)
                        {
                            var isPreSymbol = (preSymbol != null && preSymbol.length > 0);
                            var isPostSymbol = (postSymbol != null && postSymbol.length > 0);
                    
                    

                      Method run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          @Override
                          public void run()
                          {
                              Thread.currentThread().setName("Jenkins Status");
                      
                      
                        Severity
                        Category
                        Status
                        Source
                        Language