Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
backend/core/activitystreams/helpers.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function timelineToActivity has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports.timelineToActivity = function(entry) {
  var timelineentry = {
    _id: entry._id,
    verb: entry.verb,
    language: entry.language,
Severity: Minor
Found in backend/core/activitystreams/helpers.js - About 1 hr to fix

    Function userMessageCommentToTimelineEntry has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports.userMessageCommentToTimelineEntry = function(comment, verb, user, shares, inReplyTo, date) {
    Severity: Minor
    Found in backend/core/activitystreams/helpers.js - About 45 mins to fix

      Function userMessageToTimelineEntry has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      module.exports.userMessageToTimelineEntry = function(message, verb, user, shares, date) {
      Severity: Minor
      Found in backend/core/activitystreams/helpers.js - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            target: entry.target.map(function(t) {
      return {
        _id: t._id,
        objectType: t.objectType,
        id: getURN(t.objectType, t._id)
        Severity: Major
        Found in backend/core/activitystreams/helpers.js and 1 other location - About 1 hr to fix
        backend/core/activitystreams/helpers.js on lines 75..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            timelineentry.inReplyTo = entry.inReplyTo.map(function(elt) {
      return {
        _id: elt._id,
        objectType: elt.objectType,
        id: getURN(elt.objectType, elt._id)
        Severity: Major
        Found in backend/core/activitystreams/helpers.js and 1 other location - About 1 hr to fix
        backend/core/activitystreams/helpers.js on lines 65..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status