Sign upLogin

linagora/openpaas-esn

View on GitHub
Star

Showing 2,177 of 2,177 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  describe('The canEditContact function', function() {
    describe('Personal address book', function() {
      it('should return false if user has no privilege', function() {
        var addressbookShell = {};
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js and 3 other locations - About 5 days to fix
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 258..415
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 582..739
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 741..898

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 969.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  describe('The canMoveContact function', function() {
    describe('Personal address book', function() {
      it('should return false if user has no privilege', function() {
        var addressbookShell = {};
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js and 3 other locations - About 5 days to fix
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 258..415
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 417..574
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 741..898

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 969.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  describe('The canDeleteContact function', function() {
    describe('Personal address book', function() {
      it('should return false if user has no privilege', function() {
        var addressbookShell = {};
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js and 3 other locations - About 5 days to fix
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 258..415
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 417..574
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 582..739

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 969.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  describe('The canCreateContact function', function() {
    describe('Personal address book', function() {
      it('should return false if user has no privilege', function() {
        var addressbookShell = {};
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js and 3 other locations - About 5 days to fix
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 417..574
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 582..739
modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js on lines 741..898

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 969.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('The esnCollaborationMembershipRequestsPaginationProvider service', function() {
  var data, provider, collaboration, options, esnCollaborationClientService, esnCollaborationMembershipRequestsPaginationProvider, $q, $rootScope;

  beforeEach(function() {
    collaboration = {objectType: 'chat.conversation', id: 1};
Severity: Major
Found in frontend/js/modules/collaboration/services/collaboration-membership-requests-pagination-provider.service.spec.js and 1 other location - About 3 days to fix
frontend/js/modules/collaboration/services/collaboration-member-pagination-provider.service.spec.js on lines 7..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 621.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('The esnCollaborationMemberPaginationProvider service', function() {
  var data, provider, collaboration, options, esnCollaborationClientService, esnCollaborationMemberPaginationProvider, $q, $rootScope;

  beforeEach(function() {
    collaboration = {objectType: 'chat.conversation', id: 1};
Severity: Major
Found in frontend/js/modules/collaboration/services/collaboration-member-pagination-provider.service.spec.js and 1 other location - About 3 days to fix
frontend/js/modules/collaboration/services/collaboration-membership-requests-pagination-provider.service.spec.js on lines 7..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 621.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File contact-api-client.service.spec.js has 1093 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

/* global chai: false */

var expect = chai.expect;
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/services/contact-api-client.service.spec.js - About 2 days to fix

    File time-zone-selector.constants.js has 1057 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function() {
  'use strict';

  angular.module('esn.datetime')
    .constant('ESN_DATETIME_TIMEZONE', [
    Severity: Major
    Found in frontend/js/modules/datetime/time-zone-selector/time-zone-selector.constants.js - About 2 days to fix

      File app.controllers.spec.js has 1005 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';

/* global chai: false */
/* global sinon: false */
      Severity: Major
      Found in modules/linagora.esn.contact/frontend/app/app.controllers.spec.js - About 2 days to fix

        File message.js has 969 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        'use strict';

angular.module('esn.message')
  .constant('ESN_MESSAGE_TYPES', ['whatsup', 'event', 'poll'])
  .constant('ESN_MESSAGE_DEFAULT_POLL_CHOICES', [{ label: '' }, { label: '' }])
        Severity: Major
        Found in frontend/js/modules/message.js - About 2 days to fix

          Function exports has 430 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(collaborationModule) {
  return {
    addMember,
    addMembers,
    addMembershipRequest,
          Severity: Major
          Found in backend/core/collaboration/member/index.js - About 2 days to fix

            Function exports has 429 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function(dependencies) {
  const logger = dependencies('logger');
  const contactModule = dependencies('contact');
  const proxy = require('../proxy')(dependencies)(PATH);
  const avatarHelper = require('./avatarHelper')(dependencies);
            Severity: Major
            Found in modules/linagora.esn.davproxy/backend/webserver/addressbooks/controller.js - About 2 days to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                Q.denodeify(imageModule.recordAvatar)(
    avatarId,
    req.query.mimetype.toLowerCase(),
    {
      creator: {
              Severity: Major
              Found in backend/webserver/controllers/users.js and 1 other location - About 2 days to fix
              backend/webserver/controllers/users.js on lines 149..201

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 373.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                Q.denodeify(imageModule.recordAvatar)(
    avatarId,
    req.query.mimetype.toLowerCase(),
    {
      creator: {
              Severity: Major
              Found in backend/webserver/controllers/users.js and 1 other location - About 2 days to fix
              backend/webserver/controllers/users.js on lines 303..355

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 373.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File addressbook-acl-helper.servive.spec.js has 761 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              'use strict';

/* global chai: false */

var expect = chai.expect;
              Severity: Major
              Found in modules/linagora.esn.contact/frontend/app/addressbook/acl/addressbook-acl-helper.servive.spec.js - About 1 day to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                describe('The esnAttachmentDefaultPreview component', function() {
  var $rootScope, $compile;

  beforeEach(function() {
    module('esn.attachment');
                Severity: Major
                Found in frontend/js/modules/attachment/preview/default-preview/default-preview.component.spec.js and 1 other location - About 1 day to fix
                frontend/js/modules/attachment/viewer/default-viewer/default-viewer.directive.spec.js on lines 7..48

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 315.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                describe('The esnAttachmentDefaultViewer directive', function() {
  var $rootScope, $compile;

  beforeEach(function() {
    module('esn.attachment');
                Severity: Major
                Found in frontend/js/modules/attachment/viewer/default-viewer/default-viewer.directive.spec.js and 1 other location - About 1 day to fix
                frontend/js/modules/attachment/preview/default-preview/default-preview.component.spec.js on lines 7..47

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 315.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                var importContactModule = new AwesomeModule('linagora.esn.contact.import.twitter', {
  dependencies: [
    new Dependency(Dependency.TYPE_NAME, 'linagora.esn.core.logger', 'logger'),
    new Dependency(Dependency.TYPE_NAME, 'linagora.esn.contact', 'contact'),
    new Dependency(Dependency.TYPE_NAME, 'linagora.esn.contact.import', 'contact-import'),
                Severity: Major
                Found in modules/linagora.esn.contact.import.twitter/index.js and 1 other location - About 1 day to fix
                modules/linagora.esn.contact.import.google/index.js on lines 7..52

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 314.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const importContactModule = new AwesomeModule('linagora.esn.contact.import.google', {
  dependencies: [
    new Dependency(Dependency.TYPE_NAME, 'linagora.esn.core.logger', 'logger'),
    new Dependency(Dependency.TYPE_NAME, 'linagora.esn.contact', 'contact'),
    new Dependency(Dependency.TYPE_NAME, 'linagora.esn.contact.import', 'contact-import'),
                Severity: Major
                Found in modules/linagora.esn.contact.import.google/index.js and 1 other location - About 1 day to fix
                modules/linagora.esn.contact.import.twitter/index.js on lines 7..52

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 314.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                File contact-list.controller.spec.js has 745 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                'use strict';

/* global chai: false */
/* global sinon: false */
                Severity: Major
                Found in modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js - About 1 day to fix
                  Severity
                  Category
                  Status
                  Source
                  Language