Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
backend/core/collaboration/member/index.js

Summary

Maintainability
F
1 wk
Test Coverage

Function exports has 430 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(collaborationModule) {
  return {
    addMember,
    addMembers,
    addMembershipRequest,
Severity: Major
Found in backend/core/collaboration/member/index.js - About 2 days to fix

    Function exports has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function(collaborationModule) {
  return {
    addMember,
    addMembers,
    addMembershipRequest,
    Severity: Minor
    Found in backend/core/collaboration/member/index.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File index.js has 443 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

const _ = require('lodash');
const async = require('async');
const localpubsub = require('../../pubsub').local;
    Severity: Minor
    Found in backend/core/collaboration/member/index.js - About 6 hrs to fix

      Function addMembershipRequest has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function addMembershipRequest(objectType, collaboration, userAuthor, userTarget, workflow, actor, callback) {
    if (!userAuthor) {
      return callback(new Error('Author user object is required'));
    }
      Severity: Minor
      Found in backend/core/collaboration/member/index.js - About 2 hrs to fix

        Function addMembers has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function addMembers(collaboration, members, callback) {
    if (!collaboration || !members) {
      return callback(new Error('Collaboration and members are required'));
    }
        Severity: Minor
        Found in backend/core/collaboration/member/index.js - About 1 hr to fix

          Function getMembers has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function getMembers(collaboration, objectType, query = {}, callback) {
    const id = collaboration._id || collaboration;
    const Model = collaborationModule.getModel(objectType);

    if (!Model) {
          Severity: Minor
          Found in backend/core/collaboration/member/index.js - About 1 hr to fix

            Function removeMembers has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function removeMembers(collaboration, members, callback) {
    if (!collaboration || !Array.isArray(members)) {
      return callback(new Error('Collaboration and members are required'));
    }
            Severity: Minor
            Found in backend/core/collaboration/member/index.js - About 1 hr to fix

              Function addMembershipRequest has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                function addMembershipRequest(objectType, collaboration, userAuthor, userTarget, workflow, actor, callback) {
              Severity: Major
              Found in backend/core/collaboration/member/index.js - About 50 mins to fix

                Function join has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  function join(objectType, collaboration, userAuthor, userTarget, actor, callback) {
                Severity: Minor
                Found in backend/core/collaboration/member/index.js - About 45 mins to fix

                  Function cancelMembershipInvitation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    function cancelMembershipInvitation(objectType, collaboration, membership, manager, callback) {
                  Severity: Minor
                  Found in backend/core/collaboration/member/index.js - About 35 mins to fix

                    Function cancelMembershipRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      function cancelMembershipRequest(objectType, collaboration, membership, user, callback) {
                    Severity: Minor
                    Found in backend/core/collaboration/member/index.js - About 35 mins to fix

                      Function leave has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        function leave(objectType, collaboration, userAuthor, userTarget, callback) {
                      Severity: Minor
                      Found in backend/core/collaboration/member/index.js - About 35 mins to fix

                        Function refuseMembershipRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          function refuseMembershipRequest(objectType, collaboration, membership, manager, callback) {
                        Severity: Minor
                        Found in backend/core/collaboration/member/index.js - About 35 mins to fix

                          Function declineMembershipInvitation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                            function declineMembershipInvitation(objectType, collaboration, membership, user, callback) {
                          Severity: Minor
                          Found in backend/core/collaboration/member/index.js - About 35 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return callback(new Error('Only Restricted and Private collaborations allow membership requests.'));
                            Severity: Major
                            Found in backend/core/collaboration/member/index.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return callback(new Error('Invalid workflow, must be in ' + _.keys(WORKFLOW_NOTIFICATIONS_TOPIC)));
                              Severity: Major
                              Found in backend/core/collaboration/member/index.js - About 30 mins to fix

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                  function cancelMembershipRequest(objectType, collaboration, membership, user, callback) {
    cleanMembershipRequest(collaboration, membership.user, err => {
      if (err) {
        return callback(err);
      }
                                Severity: Major
                                Found in backend/core/collaboration/member/index.js and 3 other locations - About 4 hrs to fix
                                backend/core/collaboration/member/index.js on lines 181..196
                                backend/core/collaboration/member/index.js on lines 255..270
                                backend/core/collaboration/member/index.js on lines 501..516

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 118.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                  function refuseMembershipRequest(objectType, collaboration, membership, manager, callback) {
    cleanMembershipRequest(collaboration, membership.user, err => {
      if (err) {
        return callback(err);
      }
                                Severity: Major
                                Found in backend/core/collaboration/member/index.js and 3 other locations - About 4 hrs to fix
                                backend/core/collaboration/member/index.js on lines 181..196
                                backend/core/collaboration/member/index.js on lines 198..213
                                backend/core/collaboration/member/index.js on lines 255..270

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 118.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                  function declineMembershipInvitation(objectType, collaboration, membership, user, callback) {
    cleanMembershipRequest(collaboration, membership.user, err => {
      if (err) {
        return callback(err);
      }
                                Severity: Major
                                Found in backend/core/collaboration/member/index.js and 3 other locations - About 4 hrs to fix
                                backend/core/collaboration/member/index.js on lines 181..196
                                backend/core/collaboration/member/index.js on lines 198..213
                                backend/core/collaboration/member/index.js on lines 501..516

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 118.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                  function cancelMembershipInvitation(objectType, collaboration, membership, manager, callback) {
    cleanMembershipRequest(collaboration, membership.user, err => {
      if (err) {
        return callback(err);
      }
                                Severity: Major
                                Found in backend/core/collaboration/member/index.js and 3 other locations - About 4 hrs to fix
                                backend/core/collaboration/member/index.js on lines 198..213
                                backend/core/collaboration/member/index.js on lines 255..270
                                backend/core/collaboration/member/index.js on lines 501..516

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 118.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status