Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
backend/core/ldap/index.js

Summary

Maintainability
D
1 day
Test Coverage

File index.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const async = require('async');
const _ = require('lodash');
const esnConfig = require('../esn-config');
const logger = require('../logger');
const utils = require('./utils');
Severity: Minor
Found in backend/core/ldap/index.js - About 2 hrs to fix

    Function search has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function search(user, query) {
  if (!query || !user) {
    return Promise.reject(new Error('Can not authenticate from null values'));
  }
    Severity: Minor
    Found in backend/core/ldap/index.js - About 1 hr to fix

      Function ldapSearch has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function ldapSearch(domainId, ldapConf, query) {
  const {
    adminDn = '',
    adminPassword = '',
    mapping,
      Severity: Minor
      Found in backend/core/ldap/index.js - About 1 hr to fix

        Function findDomainsBoundToEmail has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function findDomainsBoundToEmail(email, callback) {
  const emailExistsInLdap = (ldap, _callback) => {
    const errorMsg = `Error while finding user ${email} in LDAP directory "${ldap.name}"`;

    emailExists(email, ldap.configuration, (err, user) => {
        Severity: Minor
        Found in backend/core/ldap/index.js - About 1 hr to fix

          Function findLDAPForUser has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function findLDAPForUser(email, callback) {
  return esnConfig('ldap').getFromAllDomains().then(configs => {
    if (!configs || configs.length === 0) {
      return callback(new Error('No configured LDAP'));
    }
          Severity: Minor
          Found in backend/core/ldap/index.js - About 1 hr to fix

            Function emailExists has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function emailExists(email, ldapConfig, callback) {
  if (!email || !ldapConfig) {
    return callback(new Error('Missing parameters'));
  }
            Severity: Minor
            Found in backend/core/ldap/index.js - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  const emailExistsInLdap = (ldap, _callback) => {
      const errorMsg = `Error while finding user ${email} in LDAP directory "${ldap.name}"`;

      emailExists(email, ldap.configuration, (err, user) => {
        if (err) {
              Severity: Major
              Found in backend/core/ldap/index.js and 1 other location - About 2 hrs to fix
              backend/core/ldap/index.js on lines 144..154

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 89.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                const emailExistsInLdap = (ldap, _callback) => {
    const errorMsg = `Error while finding user ${email} in LDAP directory "${ldap.name}"`;

    emailExists(email, ldap.configuration, (err, user) => {
      if (err) {
              Severity: Major
              Found in backend/core/ldap/index.js and 1 other location - About 2 hrs to fix
              backend/core/ldap/index.js on lines 122..132

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 89.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              module.exports = {
  findLDAPForUser,
  findDomainsBoundToEmail,
  emailExists,
  authenticate,
              Severity: Minor
              Found in backend/core/ldap/index.js and 1 other location - About 50 mins to fix
              backend/webserver/middleware/collaboration.js on lines 5..14

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status