Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
backend/webserver/controllers/platformadmins.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function removePlatformAdmin has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function removePlatformAdmin(req, res) {
  const { type, data } = req.body;
  const removePlatformAdminHandlers = {
    email: corePlatformAdmin.removePlatformAdminByEmail,
    id: corePlatformAdmin.removePlatformAdminById
Severity: Minor
Found in backend/webserver/controllers/platformadmins.js - About 1 hr to fix

    Function createPlatformAdmin has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function createPlatformAdmin(req, res) {
  const { type, data } = req.body;
  const addPlatformAdminHandlers = {
    email: corePlatformAdmin.addPlatformAdminByEmail,
    id: corePlatformAdmin.addPlatformAdminById
    Severity: Minor
    Found in backend/webserver/controllers/platformadmins.js - About 1 hr to fix

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

        corePlatformAdmin
    .getAllPlatformAdminUsers()
    .then(users => users.map(user => coreUserDenormalize.denormalize(user)))
    .then(users => users.map(user => ({
      id: user.id,
      Severity: Major
      Found in backend/webserver/controllers/platformadmins.js and 10 other locations - About 1 hr to fix
      backend/webserver/controllers/domains.js on lines 148..174
      backend/webserver/controllers/technicalusers.js on lines 25..42
      backend/webserver/controllers/technicalusers.js on lines 56..70
      backend/webserver/controllers/technicalusers.js on lines 85..99
      backend/webserver/controllers/technicalusers.js on lines 105..119
      backend/webserver/middleware/application-discovery-service.js on lines 42..63
      backend/webserver/middleware/passwordreset.js on lines 9..37
      backend/webserver/middleware/themes.js on lines 11..39
      backend/webserver/middleware/users.js on lines 20..44
      backend/webserver/middleware/users.js on lines 121..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status