Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
frontend/js/modules/activitystream/services.js

Summary

Maintainability
D
2 days
Test Coverage

File services.js has 371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

angular.module('esn.activitystream')
.factory('activitystreamAPI', function(esnRestangular) {
  function get(id, options) {
Severity: Minor
Found in frontend/js/modules/activitystream/services.js - About 4 hrs to fix

    Function activitystreamsAggregator has 83 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function activitystreamsAggregator(aggs, rpp) {
    var aggregators = aggs.map(function(agg) {
      return {aggregator: agg, items: [], runningPromise: null};
    });
    Severity: Major
    Found in frontend/js/modules/activitystream/services.js - About 3 hrs to fix

      Function applyUpdates has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function applyUpdates(uuid, $scope) {
    var cursor = getRestcursor(uuid, 30, $scope.mostRecentActivityID);

    function updateThreads(timelines, $scope) {
      timelines.forEach(function(timelineentry) {
      Severity: Minor
      Found in frontend/js/modules/activitystream/services.js - About 1 hr to fix

        Function activitystreamOriginDecorator has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          return function activitystreamOriginDecorator(streamOrigin, streams, callback) {

    function getStreamOrigins(message) {
      if (!message || !angular.isArray(streams)) {
        return [];
        Severity: Minor
        Found in frontend/js/modules/activitystream/services.js - About 1 hr to fix

          Function activitystreamMessageDecorator has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            return function activitystreamMessageDecorator(callback) {
    return function(err, items) {
      if (err) {
        return callback(err);
      }
          Severity: Minor
          Found in frontend/js/modules/activitystream/services.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              function getMessageStreamOrigins(message, streams) {
    if (!message || !angular.isArray(streams)) {
      return [];
    }
            Severity: Major
            Found in frontend/js/modules/activitystream/services.js and 1 other location - About 3 hrs to fix
            frontend/js/modules/activitystream/services.js on lines 374..384

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                function getStreamOrigins(message) {
      if (!message || !angular.isArray(streams)) {
        return [];
      }
            Severity: Major
            Found in frontend/js/modules/activitystream/services.js and 1 other location - About 3 hrs to fix
            frontend/js/modules/activitystream/services.js on lines 421..431

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 108.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  updateApiArgs: function(cursor, items, apiArgs) {
        if (items.length > 0) {
          apiArgs.before = items[(items.length - 1)]._id;
        }
      }
            Severity: Major
            Found in frontend/js/modules/activitystream/services.js and 1 other location - About 1 hr to fix
            frontend/js/modules/activitystream/services.js on lines 39..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  updateApiArgs: function(cursor, items, apiArgs) {
        if (items.length > 0) {
          apiArgs.after = items[(items.length - 1)]._id;
        }
      }
            Severity: Major
            Found in frontend/js/modules/activitystream/services.js and 1 other location - About 1 hr to fix
            frontend/js/modules/activitystream/services.js on lines 214..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var id = item.inReplyTo && item.inReplyTo.length ? item.inReplyTo[0]._id : item.object._id;
            Severity: Minor
            Found in frontend/js/modules/activitystream/services.js and 1 other location - About 40 mins to fix
            frontend/js/modules/activitystream/services.js on lines 136..136

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  var rootMessageId = item.inReplyTo && item.inReplyTo.length ? item.inReplyTo[0]._id : item.object._id;
            Severity: Minor
            Found in frontend/js/modules/activitystream/services.js and 1 other location - About 40 mins to fix
            frontend/js/modules/activitystream/services.js on lines 168..168

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status