Sign upLogin

linagora/openpaas-esn

View on GitHub
Star

Showing 1,451 of 2,177 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function countFollowers(user) {
  const options = {
    target: userAsTuple(user),
    type: CONSTANTS.FOLLOW_LINK_TYPE
  };
Severity: Minor
Found in backend/core/user/follow.js and 1 other location - About 35 mins to fix
backend/core/user/follow.js on lines 109..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

(function() {
  'use strict';

  angular.module('esn.infinite-list')
    .constant('INFINITE_LIST_EVENTS', {
Severity: Minor
Found in frontend/js/modules/infinite-list/infinite-list.constants.js and 1 other location - About 35 mins to fix
frontend/js/modules/header/profile-menu/profile-menu.component.js on lines 1..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    var viewerRegistry = esnRegistry('file-viewer', {
      match: function(contentType, provider) {
        return provider.contentType.indexOf(contentType) > -1;
      }
    });
Severity: Minor
Found in frontend/js/modules/attachment/attachment-registry.service.js and 1 other location - About 35 mins to fix
frontend/js/modules/attachment/attachment-registry.service.js on lines 14..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    $timeout(function() {
      expect(scope.sorted_contacts).to.deep.equal(sortedContacts);
      done();
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js and 3 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 548..551
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 576..579
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 606..609

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    $timeout(function() {
      expect(scope.sorted_contacts).to.deep.equal(sortedContacts);
      done();
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js and 3 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 520..523
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 576..579
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 606..609

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    $timeout(function() {
      expect(scope.sorted_contacts).to.deep.equal(sortedContacts);
      done();
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js and 3 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 520..523
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 548..551
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 606..609

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

    $timeout(function() {
      expect(scope.sorted_contacts).to.deep.equal(sortedContacts);
      done();
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js and 3 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 520..523
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 548..551
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 576..579

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('should send back 2nd contact when its fn is smaller', function() {
      expect(this.ContactShellComparator.byDisplayName(b, a)).to.equal(1);
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js and 5 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 43..45
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 51..53
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 63..65
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 72..74
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 80..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('should send back the first contact when fn are equal', function() {
      expect(this.ContactShellComparator.byDisplayName(a, a)).to.equal(0);
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js and 5 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 43..45
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 51..53
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 59..61
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 72..74
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 80..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('should send back 1st when both params do not have displayName attribute', function() {
      expect(this.ContactShellComparator.byDisplayName(anonymousUser, anonymousUser)).to.equal(0);
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js and 5 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 43..45
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 59..61
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 63..65
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 72..74
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 80..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('should send equal when both are non alpha', function() {
      expect(this.ContactShellComparator.byDisplayName(nonAlpha, thunder)).to.equal(0);
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js and 5 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 43..45
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 51..53
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 59..61
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 63..65
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 80..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('should send equal between number and non alpha', function() {
      expect(this.ContactShellComparator.byDisplayName(number, nonAlpha)).to.equal(0);
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js and 5 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 43..45
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 51..53
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 59..61
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 63..65
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 72..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    it('should send back 1st contact when second param  does not have displayName attribute', function() {
      expect(this.ContactShellComparator.byDisplayName(a, anonymousUser)).to.equal(1);
    });
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js and 5 other locations - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 51..53
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 59..61
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 63..65
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 72..74
modules/linagora.esn.contact/frontend/app/contact/shell/contact-shell-comparator.service.spec.js on lines 80..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (details) {
    return res.status(400).json({
      error: {
        code: 400,
        message: 'Bad Request',
Severity: Minor
Found in backend/webserver/middleware/domain.js and 1 other location - About 30 mins to fix
backend/webserver/middleware/users.js on lines 83..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  Object.keys(collaborationModels).forEach(function(key) {
    finders.push(async.apply(finder, key));
  });
Severity: Minor
Found in backend/core/collaboration/index.js and 1 other location - About 30 mins to fix
backend/core/collaboration/index.js on lines 99..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      var user = { _id: scope.notification.subject.id, displayName: sinon.stub().returns(displayName) };
Severity: Minor
Found in frontend/js/modules/collaboration/user-notifications/collaboration-membership-invitation.directive.spec.js and 1 other location - About 30 mins to fix
frontend/js/modules/collaboration/user-notifications/collaboration-membership-invitation.directive.spec.js on lines 108..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      var user = { _id: scope.notification.subject.id, displayName: sinon.stub().returns(displayName) };
Severity: Minor
Found in frontend/js/modules/collaboration/user-notifications/collaboration-membership-invitation.directive.spec.js and 1 other location - About 30 mins to fix
frontend/js/modules/collaboration/user-notifications/collaboration-membership-invitation.directive.spec.js on lines 64..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      RestangularConfigurer.setErrorInterceptor(function(response) {
        if (response.status === 401) {
          httpErrorHandler.redirectToLogin();
        }
Severity: Minor
Found in frontend/js/modules/http.js and 1 other location - About 30 mins to fix
modules/linagora.esn.contact/frontend/app/services/contact-restangular.service.js on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (!req.query.email && !req.query.search) {
    return res.status(400).json({
      error: {
        code: 400,
        message: 'Bad Request',
Severity: Minor
Found in backend/webserver/middleware/users.js and 1 other location - About 30 mins to fix
backend/webserver/middleware/domain.js on lines 127..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      RestangularConfigurer.setErrorInterceptor(function(response) {
        if (response.status === 401) {
          httpErrorHandler.redirectToLogin();
        }
Severity: Minor
Found in modules/linagora.esn.contact/frontend/app/services/contact-restangular.service.js and 1 other location - About 30 mins to fix
frontend/js/modules/http.js on lines 11..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language