Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
modules/linagora.esn.contact.import.google/backend/lib/mapping.js

Summary

Maintainability
F
3 days
Test Coverage

Function exports has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function() {

  function getFormattedName(json) {
    if (json.title[0]) {
      return json.title[0];
Severity: Minor
Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function() {

  function getFormattedName(json) {
    if (json.title[0]) {
      return json.title[0];
Severity: Major
Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js - About 4 hrs to fix

    Function toVcard has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function toVcard(json) {
    // See https://developers.google.com/google-apps/contacts/v3/#retrieving_a_single_contact
    // and test/unit-backend/lib/mapping.js for json sample
    var prop;
    var fn, name;
    Severity: Major
    Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js - About 2 hrs to fix

      Avoid too many return statements within this function.
      Open

            return json['gd:email'][0].$.address.replace('mailto:', '');
      Severity: Major
      Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return json['gd:phoneNumber'][0].$.uri.replace('tel:', '');
        Severity: Major
        Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return json['gContact:nickname'][0];
          Severity: Major
          Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                if (json['gd:im']) {
      json['gd:im'].forEach(function(data) {
        if (data.$ && data.$.address && data.$.protocol) {
          var prop = vcard.addPropertyWithValue('socialprofile', data.$.address);
          prop.setParameter('type', getMultiValueType(data.$.protocol));
            Severity: Major
            Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js and 2 other locations - About 4 hrs to fix
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 61..68
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 78..85

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                if (json['gd:email']) {
      json['gd:email'].forEach(function(data) {
        if (data.$ && data.$.address && data.$.rel) {
          var prop = vcard.addPropertyWithValue('email', data.$.address);
          prop.setParameter('type', getMultiValueType(data.$.rel));
            Severity: Major
            Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js and 2 other locations - About 4 hrs to fix
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 61..68
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 87..94

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                if (json['gd:phoneNumber']) {
      json['gd:phoneNumber'].forEach(function(data) {
        if (data.$ && data.$.uri && data.$.rel) {
          var prop = vcard.addPropertyWithValue('tel', data.$.uri);
          prop.setParameter('type', getMultiValueType(data.$.rel));
            Severity: Major
            Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js and 2 other locations - About 4 hrs to fix
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 78..85
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 87..94

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (json['gd:organization'][0]['gd:orgName']) {
        vcard.addPropertyWithValue('org', json['gd:organization'][0]['gd:orgName'][0]);
      }
            Severity: Minor
            Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js and 1 other location - About 35 mins to fix
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 100..102

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (json['gd:organization'][0]['gd:orgTitle']) {
        vcard.addPropertyWithValue('role', json['gd:organization'][0]['gd:orgTitle'][0]);
      }
            Severity: Minor
            Found in modules/linagora.esn.contact.import.google/backend/lib/mapping.js and 1 other location - About 35 mins to fix
            modules/linagora.esn.contact.import.google/backend/lib/mapping.js on lines 97..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status