Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
modules/linagora.esn.contact/backend/ws/contact.js

Summary

Maintainability
F
5 days
Test Coverage

Function init has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

function init(dependencies) {
  const logger = dependencies('logger');
  const pubsub = dependencies('pubsub').global;
  const io = dependencies('wsserver').io;
Severity: Minor
Found in modules/linagora.esn.contact/backend/ws/contact.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has 142 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function init(dependencies) {
  const logger = dependencies('logger');
  const pubsub = dependencies('pubsub').global;
  const io = dependencies('wsserver').io;
Severity: Major
Found in modules/linagora.esn.contact/backend/ws/contact.js - About 5 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onContactDeleted(data) {
    if (_shouldSkipNotification(data)) {
      return logger.info('Contact delete notification is skipped');
    }
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 4 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 80..95
    modules/linagora.esn.contact/backend/ws/contact.js on lines 97..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onContactUpdated(data) {
    if (_shouldSkipNotification(data)) {
      return logger.info('Contact update notification is skipped');
    }
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 4 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 63..78
    modules/linagora.esn.contact/backend/ws/contact.js on lines 97..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onContactAdded(data) {
    if (_shouldSkipNotification(data)) {
      return logger.info('Contact add notification is skipped');
    }
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 4 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 63..78
    modules/linagora.esn.contact/backend/ws/contact.js on lines 80..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onAddressbookSubscriptionDeleted(data) {
    if (data && data.bookId && data.bookName) {
      logger.info('Notifying address book subscription deleted');

      _synchronizeContactLists('contact:addressbook:subscription:deleted', {
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 3 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 114..125
    modules/linagora.esn.contact/backend/ws/contact.js on lines 127..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onAddressbookDeleted(data) {
    if (data && data.bookId && data.bookName) {
      logger.info('Notifying address book deleted');

      _synchronizeContactLists('contact:addressbook:deleted', {
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 3 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 114..125
    modules/linagora.esn.contact/backend/ws/contact.js on lines 150..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onAddressbookCreated(data) {
    if (data && data.bookId && data.bookName) {
      logger.info('Notifying address book created');

      _synchronizeContactLists('contact:addressbook:created', {
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 3 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 127..138
    modules/linagora.esn.contact/backend/ws/contact.js on lines 150..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onAddressbookSubscriptionCreated(data) {
    if (data && data.bookId && data.bookName) {
      logger.info('Notifying address book subscription created');

      _synchronizeContactLists('contact:addressbook:subscription:created', data);
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 2 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 140..148
    modules/linagora.esn.contact/backend/ws/contact.js on lines 173..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onAddressbookUpdated(data) {
    if (data && data.bookId && data.bookName) {
      logger.info('Notifying address book updated');

      _synchronizeContactLists('contact:addressbook:updated', data);
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 2 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 163..171
    modules/linagora.esn.contact/backend/ws/contact.js on lines 173..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      function _onAddressbookSubscriptionUpdated(data) {
    if (data && data.bookId && data.bookName) {
      logger.info('Notifying address book subscription updated');

      _synchronizeContactLists('contact:addressbook:subscription:updated', data);
    Severity: Major
    Found in modules/linagora.esn.contact/backend/ws/contact.js and 2 other locations - About 2 hrs to fix
    modules/linagora.esn.contact/backend/ws/contact.js on lines 140..148
    modules/linagora.esn.contact/backend/ws/contact.js on lines 163..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status