Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should set file if file type is text/x-vcard', function() {
      var addressbook = {
        bookName: '123',
        name: 'adb-name'
      };
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js and 1 other location - About 7 hrs to fix
modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js on lines 101..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should set file if file type is text/vcard', function() {
      var addressbook = {
        bookName: '123',
        name: 'adb-name'
      };
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js and 1 other location - About 7 hrs to fix
modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js on lines 119..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 189.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should set status to "error" if failed to list address books', function() {
      contactAddressbookService.listAddressbooksUserCanCreateContact = sinon.stub().returns($q.reject('an error'));

      var controller = initController();
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js and 4 other locations - About 2 hrs to fix
modules/linagora.esn.contact/frontend/app/controllers/contact-list.controller.spec.js on lines 173..178
modules/linagora.esn.contact/frontend/app/sidebar/sidebar.controller.spec.js on lines 77..83
modules/linagora.esn.profile/frontend/app/edit/profile-edit.controller.spec.js on lines 135..141
modules/linagora.esn.profile/frontend/app/edit/profile-edit.controller.spec.js on lines 151..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should set status to "loading"', function() {
      var controller = $controller('ContactAddressbookImportController', { $scope: $rootScope.$new() });

      controller.$onInit();
      expect(controller.status).to.equal('loading');
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js and 1 other location - About 1 hr to fix
modules/linagora.esn.contact/frontend/app/sidebar/sidebar.controller.spec.js on lines 61..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  function initController() {
    var $scope = $rootScope.$new();
    var controller = $controller('ContactAddressbookImportController', { $scope: $scope });

    controller.$onInit();
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js and 2 other locations - About 1 hr to fix
frontend/js/modules/search/form/advanced/search-advanced-form.controller.spec.js on lines 28..37
modules/linagora.esn.contact/frontend/app/sidebar/sidebar.controller.spec.js on lines 50..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    module(function($provide) {
      esnConfigMock = function() {
        return $q.when(true);
      };
Severity: Minor
Found in modules/linagora.esn.contact/frontend/app/addressbook/import/contact-addressbook-import.controller.spec.js and 2 other locations - About 40 mins to fix
modules/linagora.esn.contact/frontend/app/contact/form/contact-edition-form.directive.spec.js on lines 16..22
modules/linagora.esn.contact/frontend/app/sidebar/sidebar.controller.spec.js on lines 16..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status