Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js

Summary

Maintainability
F
1 wk
Test Coverage

File contact.service.spec.js has 694 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

/* global chai, sinon: false */

var expect = chai.expect;
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js - About 1 day to fix

    Function addressbookHome has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          ContactAPIClient.addressbookHome = function(bookId) {
        return {
          addressbook: function(bookName) {

            return {
    Severity: Minor
    Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js - About 1 hr to fix

      Function addressbookHome has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            ContactAPIClient.addressbookHome = function(bookId) {
        return {
          addressbook: function(bookName) {

            return {
      Severity: Minor
      Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js - About 1 hr to fix

        Function addressbookHome has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              ContactAPIClient.addressbookHome = function(bookId) {
        return {
          addressbook: function(bookName) {

            return {
        Severity: Minor
        Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              it('should update contact in source address book if the current one is subscription', function(done) {
      var subsBookId = '123';
      var subsBookName = 'contacts';
      var sourceBookId = '456';
      var sourceBookName = 'collected';
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 1 day to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 402..444

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 246.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              it('should remove contact from source address book if the current one is subscription', function(done) {
      var subsBookId = '123';
      var subsBookName = 'contacts';
      var sourceBookId = '456';
      var sourceBookName = 'collected';
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 1 day to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 319..362

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 246.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              it('should call ContactAPIClient with right parameters to get the list of contacts', function(done) {
      var bookId = '1213';
      var bookName = 'contacts';

      ContactAPIClient.addressbookHome = function(currentBookId) {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 7 hrs to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 120..151

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 186.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              it('should call ContactAPIClient with right parameters to get the contact', function(done) {
      var bookId = '1213';
      var bookName = 'contacts';

      ContactAPIClient.addressbookHome = function(currentBookId) {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 7 hrs to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 45..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 186.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                ContactAPIClient.addressbookHome = function(bookId) {
        return {
          addressbook: function(bookName) {

            return {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 5 hrs to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 376..396

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 141.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                ContactAPIClient.addressbookHome = function(currentBookId) {
        return {
          addressbook: function(currentBookName) {

            return {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 5 hrs to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 496..516

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 141.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

                        get: function() {
                return $q.when({
                  bookId: subsBookId,
                  bookName: subsBookName,
                  source: {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 3 other locations - About 55 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 89..99
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 165..175
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 760..770

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

                        get: function() {
                return $q.when({
                  bookId: subsBookId,
                  bookName: subsBookName,
                  source: {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 3 other locations - About 55 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 165..175
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 249..259
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 760..770

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

                        get: function() {
                return $q.when({
                  bookId: subsBookId,
                  bookName: subsBookName,
                  source: {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 3 other locations - About 55 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 89..99
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 249..259
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 760..770

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

                        get: function() {
                return $q.when({
                  bookId: subsBookId,
                  bookName: subsBookName,
                  source: {
          Severity: Major
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 3 other locations - About 55 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 89..99
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 165..175
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 249..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                expect(davImportServiceMock.importFromFile).to.have.been.calledWith(file[0], '/addressbooks/' + sourceBookId + '/' + sourceBookName + '.json');
          Severity: Minor
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 50 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 746..746

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                expect(davImportServiceMock.importFromFile).to.have.been.calledWith(file[0], '/addressbooks/' + bookId + '/' + bookName + '.json');
          Severity: Minor
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 50 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 780..780

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              expect(options).to.deep.equal({
                      toBookId: toAddressbook.source.bookId,
                      toBookName: toAddressbook.source.bookName
                    });
          Severity: Minor
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 45 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 592..595

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              expect(options).to.deep.equal({
                      toBookId: toAddressbook.source.bookId,
                      toBookName: toAddressbook.source.bookName
                    });
          Severity: Minor
          Found in modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js and 1 other location - About 45 mins to fix
          modules/linagora.esn.contact/frontend/app/contact/contact.service.spec.js on lines 703..706

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status