Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
modules/linagora.esn.contact/frontend/app/services/contact-highlight-helpers.service.js

Summary

Maintainability
C
1 day
Test Coverage

Function ContactHighLightHelper has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function ContactHighLightHelper() {
    return ContactHighLightHelper;

    function ContactHighLightHelper() {
      var dataHighlight = [];
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/services/contact-highlight-helpers.service.js - About 3 hrs to fix

    Function ContactHighLightHelper has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function ContactHighLightHelper() {
      var dataHighlight = [];

      return {
        checkArrMatching: checkArrMatching,
    Severity: Major
    Found in modules/linagora.esn.contact/frontend/app/services/contact-highlight-helpers.service.js - About 2 hrs to fix

      Function checkArrAddressMatching has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            function checkArrAddressMatching(array, query, iconClass) {
        function getMinOfArray(numArray) {
          return Math.min.apply(null, numArray);
        }
        if (typeof array === 'undefined') {
      Severity: Minor
      Found in modules/linagora.esn.contact/frontend/app/services/contact-highlight-helpers.service.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    var str = array[i].street + ' ' + array[i].city + ' ' + array[i].country + ' ' + array[i].zip;
        Severity: Major
        Found in modules/linagora.esn.contact/frontend/app/services/contact-highlight-helpers.service.js and 1 other location - About 1 hr to fix
        tasks/utils/Gruntfile-utils.js on lines 85..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status