Sign upLogin

linagora/openpaas-esn

View on GitHub
Star
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should create a ContactSharree object from user which has email but not preferredEmail', function() {
      userUtils.displayNameOf = sinon.stub().returns('toto');
      var user = {
        _id: '58e66c5bd69a39451f57c819',
        email: 'toto@example.com'
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js and 1 other location - About 1 day to fix
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 145..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 263.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should create a ContactSharree object from user and access right code', function() {
      userUtils.displayNameOf = sinon.stub().returns('toto');
      var user = {
        _id: '58e66c5bd69a39451f57c819',
        preferredEmail: 'toto@example.com'
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js and 1 other location - About 1 day to fix
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 165..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 263.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it('should throw error if there is no href', function() {
      delete jsonData.href;

      try {
        new ContactSharee(jsonData);
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js and 3 other locations - About 1 hr to fix
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 55..63
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 65..73
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 75..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it('should throw error if userId is undefined', function() {
      delete jsonData.userId;

      try {
        new ContactSharee(jsonData);
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js and 3 other locations - About 1 hr to fix
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 45..53
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 55..63
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 65..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it('should throw error if access is undefined', function() {
      delete jsonData.access;

      try {
        new ContactSharee(jsonData);
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js and 3 other locations - About 1 hr to fix
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 45..53
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 65..73
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 75..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    it('should throw error if inviteStatus is undefined', function() {
      delete jsonData.inviteStatus;

      try {
        new ContactSharee(jsonData);
Severity: Major
Found in modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js and 3 other locations - About 1 hr to fix
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 45..53
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 55..63
modules/linagora.esn.contact/frontend/app/sharing/sharee/contact-sharee.service.spec.js on lines 75..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status