linagora/openpaas-esn

View on GitHub
modules/linagora.esn.messaging.email/lib/sender.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 198 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(lib, dependencies) {

  var logger = dependencies('logger');

  function getSenderAddress(emailtoken, callback) {
Severity: Major
Found in modules/linagora.esn.messaging.email/lib/sender.js - About 7 hrs to fix

    Function exports has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function(lib, dependencies) {
    
      var logger = dependencies('logger');
    
      function getSenderAddress(emailtoken, callback) {
    Severity: Minor
    Found in modules/linagora.esn.messaging.email/lib/sender.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function listen has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function listen() {
    
        var pubsub = dependencies('pubsub').local;
        pubsub.topic('message:activity').subscribe(function(activity) {
    
    
    Severity: Major
    Found in modules/linagora.esn.messaging.email/lib/sender.js - About 2 hrs to fix

      Function notify has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function notify(user, message, data, context, callback) {
      
          if (!user) {
            return callback(new Error('User is required'));
          }
      Severity: Minor
      Found in modules/linagora.esn.messaging.email/lib/sender.js - About 1 hr to fix

        Function sendMessageAsEmails has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function sendMessageAsEmails(message, recipients, callback) {
            if (!message) {
              return callback(new Error('Message is required'));
            }
        
        
        Severity: Minor
        Found in modules/linagora.esn.messaging.email/lib/sender.js - About 1 hr to fix

          Function sendMail has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            function sendMail(from, user, message, context, callback) {
          Severity: Minor
          Found in modules/linagora.esn.messaging.email/lib/sender.js - About 35 mins to fix

            Function notify has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              function notify(user, message, data, context, callback) {
            Severity: Minor
            Found in modules/linagora.esn.messaging.email/lib/sender.js - About 35 mins to fix

              There are no issues that match your filters.

              Category
              Status