Sign upLogin

linitix/nzero-push

View on GitHub
Star

Showing 52 of 52 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

ZeroPush.prototype.setBadge = function (deviceTokens, badge, callback) {
  if ( typeof deviceTokens === "function" )
    callback = deviceTokens;
  if ( typeof badge === "function" )
    callback = badge;
Severity: Major
Found in lib/zero_push.js and 4 other locations - About 2 hrs to fix
lib/zero_push.js on lines 32..42
lib/zero_push.js on lines 44..54
lib/zero_push.js on lines 152..162
lib/zero_push.js on lines 164..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

ZeroPush.prototype.appendToChannelSubscriptionForDevices = function (deviceTokens, channels, callback) {
  if ( typeof  deviceTokens === "function" )
    callback = deviceTokens;
  if ( typeof  channels === "function" )
    callback = channels;
Severity: Major
Found in lib/zero_push.js and 4 other locations - About 2 hrs to fix
lib/zero_push.js on lines 32..42
lib/zero_push.js on lines 44..54
lib/zero_push.js on lines 78..88
lib/zero_push.js on lines 152..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

ZeroPush.prototype.broadcast = function (channel, notification, callback) {
  if ( typeof channel === "function" )
    callback = channel;
  if ( typeof notification === "function" )
    callback = notification;
Severity: Major
Found in lib/zero_push.js and 4 other locations - About 2 hrs to fix
lib/zero_push.js on lines 32..42
lib/zero_push.js on lines 78..88
lib/zero_push.js on lines 152..162
lib/zero_push.js on lines 164..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    case Utils.PLATFORMS.IOS_MACOS:
      iosMacosNotificationErrors = Utils.validateJSONWithSchema(notification, "ios_macos_notification", iosMacosNotificationSchema);

      if ( iosMacosNotificationErrors )
        return callback(new InvalidPayloadError("Invalid iOS or MacOS notification object", iosMacosNotificationErrors));
Severity: Major
Found in lib/endpoints/notify_endpoint.js and 2 other locations - About 2 hrs to fix
lib/endpoints/notify_endpoint.js on lines 36..45
lib/endpoints/notify_endpoint.js on lines 56..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    case Utils.PLATFORMS.ANDROID:
      androidNotificationErrors = Utils.validateJSONWithSchema(notification, "android_notification", androidNotificationSchema);

      if ( androidNotificationErrors )
        return callback(new InvalidPayloadError("Invalid Android notification object", androidNotificationErrors));
Severity: Major
Found in lib/endpoints/notify_endpoint.js and 2 other locations - About 2 hrs to fix
lib/endpoints/notify_endpoint.js on lines 46..55
lib/endpoints/notify_endpoint.js on lines 56..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    case Utils.PLATFORMS.SAFARI:
      safariNotificationErrors = Utils.validateJSONWithSchema(notification, "safari_notification", safariNotificationSchema);

      if ( safariNotificationErrors )
        return callback(new InvalidPayloadError("Invalid Safari notification object", safariNotificationErrors));
Severity: Major
Found in lib/endpoints/notify_endpoint.js and 2 other locations - About 2 hrs to fix
lib/endpoints/notify_endpoint.js on lines 36..45
lib/endpoints/notify_endpoint.js on lines 46..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ZeroPush.prototype.channel = function (name, callback) {
  if ( typeof name === "function" )
    callback = name;

  if ( typeof callback !== "function" )
Severity: Major
Found in lib/zero_push.js and 3 other locations - About 1 hr to fix
lib/zero_push.js on lines 56..64
lib/zero_push.js on lines 116..124
lib/zero_push.js on lines 142..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ZeroPush.prototype.deleteChannels = function (channels, callback) {
  if ( typeof channels === "function" )
    callback = channels;

  if ( typeof callback !== "function" )
Severity: Major
Found in lib/zero_push.js and 3 other locations - About 1 hr to fix
lib/zero_push.js on lines 56..64
lib/zero_push.js on lines 106..114
lib/zero_push.js on lines 142..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ZeroPush.prototype.unregister = function (deviceTokens, callback) {
  if ( typeof  deviceTokens === "function" )
    callback = deviceTokens;

  if ( typeof callback !== "function" )
Severity: Major
Found in lib/zero_push.js and 3 other locations - About 1 hr to fix
lib/zero_push.js on lines 106..114
lib/zero_push.js on lines 116..124
lib/zero_push.js on lines 142..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ZeroPush.prototype.device = function (deviceToken, callback) {
  if ( typeof deviceToken === "function" )
    callback = deviceToken;

  if ( typeof callback !== "function" )
Severity: Major
Found in lib/zero_push.js and 3 other locations - About 1 hr to fix
lib/zero_push.js on lines 56..64
lib/zero_push.js on lines 106..114
lib/zero_push.js on lines 116..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function devices has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RequestsManager.prototype.devices = function (page, perPage, callback) {
  var self     = this;
  var finished = false;
  var data     = [];
Severity: Minor
Found in lib/common/requests_manager.js - About 1 hr to fix

    Function channels has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    RequestsManager.prototype.channels = function (page, perPage, callback) {
  var self     = this;
  var finished = false;
  var data     = [];
    Severity: Minor
    Found in lib/common/requests_manager.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            self.requestsManager.unregister(deviceToken, function (err) {
        if ( err )
          data.registered.push({ device_token: deviceToken, error: err });
        else
          data.unregistered.push({ device_token: deviceToken });
      Severity: Major
      Found in lib/endpoints/unregister_endpoint.js and 2 other locations - About 1 hr to fix
      lib/endpoints/register_endpoint.js on lines 45..52
      lib/endpoints/set_badge_endpoint.js on lines 49..56

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            self.requestsManager.setBadge(deviceToken, badge, function (err) {
        if ( err )
          data.badgeNotSet.push({ device_token: deviceToken, error: err });
        else
          data.badgeSet.push({ device_token: deviceToken });
      Severity: Major
      Found in lib/endpoints/set_badge_endpoint.js and 2 other locations - About 1 hr to fix
      lib/endpoints/register_endpoint.js on lines 45..52
      lib/endpoints/unregister_endpoint.js on lines 39..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            self.requestsManager.register(deviceToken, null, function (err) {
        if ( err )
          data.unregistered.push({ device_token: deviceToken, error: err });
        else
          data.registered.push({ device_token: deviceToken });
      Severity: Major
      Found in lib/endpoints/register_endpoint.js and 2 other locations - About 1 hr to fix
      lib/endpoints/set_badge_endpoint.js on lines 49..56
      lib/endpoints/unregister_endpoint.js on lines 39..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function (platform, deviceTokens, notification, callback, self) {
  var platformErrors,
      deviceTokenErrors,
      iosMacosNotificationErrors,
      safariNotificationErrors,
      Severity: Minor
      Found in lib/endpoints/notify_endpoint.js - About 1 hr to fix

        Function registerDeviceTokensForChannels has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function registerDeviceTokensForChannels(deviceTokens, channels, callback, self) {
  var channelsErrors = Utils.validateJSONWithSchema(channels, "channels", channelsSchema);

  if ( channelsErrors )
    return callback(new InvalidPayloadError("Channels must be an array with at least one item or unique items of type string", channelsErrors));
        Severity: Minor
        Found in lib/endpoints/register_endpoint.js - About 1 hr to fix

          Function exports has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function (deviceTokens, channels, callback, self) {
  var deviceTokensErrors,
      channelsErrors;
  var data = {
    appended   : [],
          Severity: Minor
          Found in lib/endpoints/append_to_channel_subscriptions_for_devices_endpoint.js - About 1 hr to fix

            Function exports has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function (deviceTokens, channels, callback, self) {
  var deviceTokensErrors,
      channelsErrors;
  var data = {
    replaced   : [],
            Severity: Minor
            Found in lib/endpoints/replace_channel_subscriptions_for_devices_endpoint.js - About 1 hr to fix

              Function executeRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function executeRequest(requestOptions, callback) {
  debug("Executing request \"" + requestOptions.url + "\" ...");

  request(requestOptions, function (err, res, body) {
    if ( err )
              Severity: Minor
              Found in lib/common/requests_manager.js - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language