Sign upLogin

linkedin/kafka-tools

View on GitHub
Star
kafka/tools/protocol/responses/__init__.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function _decode_plain_type has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def _decode_plain_type(value_type, buf):
    if value_type == 'int8':
        return buf.getInt8()
    elif value_type == 'int16':
        return buf.getInt16()
Severity: Minor
Found in kafka/tools/protocol/responses/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return None if val_len == -1 else buf.get(val_len).decode("utf-8")
Severity: Major
Found in kafka/tools/protocol/responses/__init__.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return None if val_len == -1 else buf.get(val_len)
    Severity: Major
    Found in kafka/tools/protocol/responses/__init__.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return buf.getInt8() == 1
      Severity: Major
      Found in kafka/tools/protocol/responses/__init__.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status