linuxmuster/linuxmuster-linuxclient7

View on GitHub
usr/lib/python3/dist-packages/linuxmusterLinuxclient7/shares.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function unmountAllSharesOfUser has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def unmountAllSharesOfUser(username):
    """
    Unmount all shares of a given user and safely delete the mountpoints and the parent directory.

    :param username: The username of the user
Severity: Minor
Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/shares.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _mountShare has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def _mountShare(username, networkPath, shareName, hiddenShare, useCruidOfExecutingUser=False):

    mountpoint = _getShareMountpoint(networkPath, username, hiddenShare, shareName)

    mountCommandOptions = f"file_mode=0700,dir_mode=0700,sec=krb5,nodev,nosuid,mfsymlinks,nobrl,vers=3.0,user={username}"
Severity: Minor
Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/shares.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _mountShare has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def _mountShare(username, networkPath, shareName, hiddenShare, useCruidOfExecutingUser=False):
Severity: Minor
Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/shares.py - About 35 mins to fix

    Function _unmountShare has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _unmountShare(mountpoint):
        # check if mountpoint exists
        if (not os.path.exists(mountpoint)) or (not os.path.isdir(mountpoint)):
            logging.warning(f"* Could not unmount {mountpoint}, it does not exist.")
    
    
    Severity: Minor
    Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/shares.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status