Sign upLogin

lipp/node-jet

View on GitHub
Star
src/3_jet/messages.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function castMessage has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

export const castMessage = <T extends MethodRequest>(msg: MethodRequest): T => {
  if (!('method' in msg)) throw new invalidRequest('No method')
  const method = msg.method as EventType
  const params = msg.params
  switch (method) {
Severity: Minor
Found in src/3_jet/messages.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function castMessage has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const castMessage = <T extends MethodRequest>(msg: MethodRequest): T => {
  if (!('method' in msg)) throw new invalidRequest('No method')
  const method = msg.method as EventType
  const params = msg.params
  switch (method) {
Severity: Minor
Found in src/3_jet/messages.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

          return msg as T
    Severity: Major
    Found in src/3_jet/messages.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return msg as T
      Severity: Major
      Found in src/3_jet/messages.ts - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status