Sign upLogin

liquidm/z-http-request

View on GitHub
Star
lib/z-http/decoders.rb

Summary

Maintainability
D
2 days
Test Coverage

Method extract_stream has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
Open

    def extract_stream(compressed)
      @data << compressed
      pos = @pos

      while !eof? && !finished?
Severity: Minor
Found in lib/z-http/decoders.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extract_stream has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def extract_stream(compressed)
      @data << compressed
      pos = @pos

      while !eof? && !finished?
Severity: Major
Found in lib/z-http/decoders.rb - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                  if buffer == 0
                @state = :comment
                break
              end
    Severity: Major
    Found in lib/z-http/decoders.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                    if buffer == 0
                @state = :hcrc
                break
              end
      Severity: Major
      Found in lib/z-http/decoders.rb - About 45 mins to fix

        Method finalize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def finalize
      if @zstream
        if !@zstream.finished?
          r = @zstream.finish
        end
        Severity: Minor
        Found in lib/z-http/decoders.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status