Sign upLogin

liquidm/zmachine

View on GitHub
Star

Showing 31 of 31 total issues

Class Connection has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Connection

    extend Forwardable

    attr_accessor :channel
Severity: Minor
Found in lib/zmachine/connection.rb - About 4 hrs to fix

    Class Reactor has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Reactor

    @mutex = Mutex.new

    def self.register_reactor(reactor)
    Severity: Minor
    Found in lib/zmachine/reactor.rb - About 2 hrs to fix

      Method set_deferred_status has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def set_deferred_status(status, *args)
      cancel_timeout
      @errbacks ||= nil
      @callbacks ||= nil
      @deferred_status = status
      Severity: Minor
      Found in lib/zmachine/deferrable.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process_events has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          def process_events
      return unless valid?
      ZMachine.logger.debug("zmachine:connection:#{__method__}", connection: self) if ZMachine.debug
      if @channel_key.connectable?
        connectable!
      Severity: Minor
      Found in lib/zmachine/connection.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_inbound_data has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def read_inbound_data
      ZMachine.logger.debug("zmachine:tcp_msg_channel:#{__method__}", channel: self) if ZMachine.debug
      raise IOException.new("EOF") if @socket.read(@buffer) == -1

      pos = @buffer.position
      Severity: Minor
      Found in lib/zmachine/tcp_msg_channel.rb - About 1 hr to fix

        Method unbind_connection has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def unbind_connection(connection)
      after_writing = false
      reason = nil
      connection, after_writing, reason = *connection if connection.is_a?(Array)
      if connection.method(:unbind).arity != 0
        Severity: Minor
        Found in lib/zmachine/connection_manager.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method read_inbound_data has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def read_inbound_data
      ZMachine.logger.debug("zmachine:tcp_msg_channel:#{__method__}", channel: self) if ZMachine.debug
      raise IOException.new("EOF") if @socket.read(@buffer) == -1

      pos = @buffer.position
        Severity: Minor
        Found in lib/zmachine/tcp_msg_channel.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method write_outbound_data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def write_outbound_data
      ZMachine.logger.debug("zmachine:channel:#{__method__}", channel: self, can_send: can_send?) if ZMachine.debug
      while can_send?
        buffer = @outbound_queue.peek
        break unless buffer
        Severity: Minor
        Found in lib/zmachine/channel.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run_reactor has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def run_reactor
      ZMachine.logger.debug("zmachine:reactor:#{__method__}") if ZMachine.debug
      run_deferred_callbacks
      return unless @run_reactor
      @wheel.advance
        Severity: Minor
        Found in lib/zmachine/reactor.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def run(callback=nil, shutdown_hook=nil, &block)
      ZMachine.logger.debug("zmachine:reactor:#{__method__}") if ZMachine.debug
      add_shutdown_hook(shutdown_hook) if shutdown_hook
      begin
        Reactor.register_reactor(self)
        Severity: Minor
        Found in lib/zmachine/reactor.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method readable! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def readable!
      ZMachine.logger.debug("zmachine:connection:#{__method__}", connection: self) if ZMachine.debug
      loop do
        mark_active!
        data = @channel.read_inbound_data
        Severity: Minor
        Found in lib/zmachine/connection.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def run(callback=nil, shutdown_hook=nil, &block)
      ZMachine.logger.debug("zmachine:reactor:#{__method__}") if ZMachine.debug
      add_shutdown_hook(shutdown_hook) if shutdown_hook
      begin
        Reactor.register_reactor(self)
        Severity: Minor
        Found in lib/zmachine/reactor.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if @buffer.remaining >= 4
          bytes = java.util.Arrays.copyOfRange(@buffer.array, @buffer.position, @buffer.position+4)
          @buffer.position(@buffer.position+4)
          data_length = String.from_java_bytes(bytes).unpack('V')[0]
        else
          Severity: Minor
          Found in lib/zmachine/tcp_msg_channel.rb and 1 other location - About 45 mins to fix
          lib/zmachine/tcp_msg_channel.rb on lines 56..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if @buffer.remaining >= 4
        bytes = java.util.Arrays.copyOfRange(@buffer.array, @buffer.position, @buffer.position+4)
        @buffer.position(@buffer.position+4)
        array_length = String.from_java_bytes(bytes).unpack('V')[0]
      else
          Severity: Minor
          Found in lib/zmachine/tcp_msg_channel.rb and 1 other location - About 45 mins to fix
          lib/zmachine/tcp_msg_channel.rb on lines 69..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method start_server has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def self.start_server(server, port_or_type=nil, handler=nil, *args, &block)
          Severity: Minor
          Found in lib/zmachine.rb - About 35 mins to fix

            Method connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def connect(server, port_or_type=nil, handler=nil, *args, &block)
            Severity: Minor
            Found in lib/zmachine/reactor.rb - About 35 mins to fix

              Method connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def self.connect(server, port_or_type=nil, handler=nil, *args, &block)
              Severity: Minor
              Found in lib/zmachine.rb - About 35 mins to fix

                Method bind has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def bind(address, port_or_type, handler, *args, &block)
                Severity: Minor
                Found in lib/zmachine/connection_manager.rb - About 35 mins to fix

                  Method bind has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def bind(server, port_or_type=nil, handler=nil, *args, &block)
                  Severity: Minor
                  Found in lib/zmachine/reactor.rb - About 35 mins to fix

                    Method connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def connect(address, port_or_type, handler, *args, &block)
                    Severity: Minor
                    Found in lib/zmachine/connection_manager.rb - About 35 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language