Sign upLogin

litemerafrukt/gomokuai

View on GitHub
Star

Showing 11 of 11 total issues

Function nextBestMove has a Cognitive Complexity of 140 (exceeds 5 allowed). Consider refactoring.
Open

function nextBestMove(board, boardSize) {
    var m,
        l,
        position,
        type,
Severity: Minor
Found in src/ai.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

                    if (
                        // vertical
                        ((j === 0 &&
                            (position = i + boardSize * m) !== false &&
                            n == position % boardSize) ||
Severity: Critical
Found in src/ai.js - About 1 day to fix

    Function nextBestMove has 128 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function nextBestMove(board, boardSize) {
    var m,
        l,
        position,
        type,
    Severity: Major
    Found in src/ai.js - About 5 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          for (
                        l = line.indexOf(i) - 1;
                        l >= 0;
                        // if the cell is of the same type,
                        //increment the number of consecutive cells
      Severity: Major
      Found in src/ai.js and 1 other location - About 1 hr to fix
      src/ai.js on lines 176..197

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          for (
                        l = line.indexOf(i);
                        l < line.length;
                        // if the cell is of the same type,
                        // increment the number of consecutive cells
      Severity: Major
      Found in src/ai.js and 1 other location - About 1 hr to fix
      src/ai.js on lines 152..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid deeply nested control flow statements.
      Open

                          if (!m) {
                        board[i] = 0;
                    }
      Severity: Major
      Found in src/ai.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            for (l = 5; l--; ) {
                        if (board[line[l + 1]] == type) {
                            totalCells++;
                        }
                    }
        Severity: Major
        Found in src/ai.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if (
                        // vertical
                        ((j === 0 &&
                            (position = i + boardSize * m) !== false &&
                            n == position % boardSize) ||
          Severity: Major
          Found in src/ai.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                for (
                        l = line.indexOf(i) - 1;
                        l >= 0;
                        // if the cell is of the same type,
                        //increment the number of consecutive cells
            Severity: Major
            Found in src/ai.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  for (
                        l = line.indexOf(i);
                        l < line.length;
                        // if the cell is of the same type,
                        // increment the number of consecutive cells
              Severity: Major
              Found in src/ai.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if (score > directionScore[type - 1]) {
                        directionScore[type - 1] = score;
                    }
                Severity: Major
                Found in src/ai.js - About 45 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language