little-bobby-tables/elasticfusion

View on GitHub
lib/elasticfusion/model/indexing.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method included has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def self.included(model)
        model.class_eval do
          after_commit(on: :create) do
            __elasticsearch__.index_document
          end
Severity: Minor
Found in lib/elasticfusion/model/indexing.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Add an empty line after magic comments.
Open

require 'elasticfusion/jobs/reindex_job'
Severity: Minor
Found in lib/elasticfusion/model/indexing.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

There are no issues that match your filters.

Category
Status