Sign upLogin

livingsocial/rearview-engine

View on GitHub
Star
lib/rearview/templates/utilities.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method deploy_check has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def deploy_check(num_points, deploy, metric)
    if metric == deploy
      raise "Error: You've passed the deploy metric to be analyzed against itself, which is not a valid analysis."
    elsif metric.values.size < (num_points * 2) + 1
      raise "Error: Not enough data to evaluate. There must be #{num_points} data points before and after a deploy."
Severity: Minor
Found in lib/rearview/templates/utilities.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method percentage_errors has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def percentage_errors(metric, comparison_metrics, limit_value, limit_type, minutes = @minutes)
Severity: Minor
Found in lib/rearview/templates/utilities.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status