Sign upLogin

lml/fine_print

View on GitHub
Star

Showing 3 of 3 total issues

Method fine_print_require has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def fine_print_require(*names)
          options = names.last.is_a?(Hash) ? names.pop : {}
          f_opts = options.except(*FinePrint::Configuration::CONTROLLER_OPTIONS)

          # Convert names to an array of Strings
Severity: Minor
Found in lib/fine_print/action_controller/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fine_print_require has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def fine_print_require(*names)
        options = names.last.is_a?(Hash) ? names.pop : {}
        fp_opts = options.slice(*FinePrint::Configuration::CONTROLLER_OPTIONS)

        # Convert names to an array of Strings
Severity: Minor
Found in lib/fine_print/action_controller/base.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method publish has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def publish
      errors.add(:base, I18n.t('fine_print.contract.errors.already_published')) \
        if is_published?
      return false unless errors.empty?
Severity: Minor
Found in app/models/fine_print/contract.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language