Sign upLogin

localstack/localstack

View on GitHub
Star
localstack-core/localstack/utils/server/tcp_proxy.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function _handle_request has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def _handle_request(self, s_src: socket.socket):
        try:
            s_dst = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
            with s_src as s_src, s_dst as s_dst:
                s_dst.connect((self._target_address, self._target_port))
Severity: Minor
Found in localstack-core/localstack/utils/server/tcp_proxy.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function do_run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def do_run(self):
        self._server_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
        self._server_socket.bind((self.host, self.port))
        self._server_socket.listen(1)
        self._server_socket.settimeout(10)
Severity: Minor
Found in localstack-core/localstack/utils/server/tcp_proxy.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                            if self._handler:
                                forward, response = self._handler(data)
                            if forward is not None:
Severity: Major
Found in localstack-core/localstack/utils/server/tcp_proxy.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                if forward is not None:
                                s_dst.sendall(forward)
                            elif response is not None:
                                s_src.sendall(response)
                                return
    Severity: Major
    Found in localstack-core/localstack/utils/server/tcp_proxy.py - About 45 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Minor
      Found in localstack-core/localstack/utils/server/tcp_proxy.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status